You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2016/03/31 10:39:02 UTC

[GitHub] couchdb-fauxton pull request: Webpack fixes

GitHub user garrensmith opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/674

    Webpack fixes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/garrensmith/couchdb-fauxton webpack-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #674
    
----
commit a622a02daffdd6d263e60a56b9a15098f88936f6
Author: Garren Smith <ga...@gmail.com>
Date:   2016-03-31T08:26:52Z

    add Zeroclipboard to deploy process

commit a3e002661cce90f614565a822c84e8ee6cb02bce
Author: Garren Smith <ga...@gmail.com>
Date:   2016-03-31T08:27:11Z

    remove unneeded libraries

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Webpack fixes

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/674#issuecomment-203954265
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Webpack fixes

Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/674#issuecomment-204421953
  
    Ah brilliant, thanks Garren. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Webpack fixes

Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/674#issuecomment-204418394
  
    Can we merge this one in today, @garrensmith? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Webpack fixes

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/674


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Webpack fixes

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/674#issuecomment-204419707
  
    It's already merged in. Sorry I forgot to close. 
    
    All misspelling thanks to my iPhone
    
    > On 01 Apr 2016, at 4:33 PM, Benjamin Keen <no...@github.com> wrote:
    > 
    > Can we merge this one in today, @garrensmith?
    > 
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly or view it on GitHub
    > 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Webpack fixes

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/674#discussion_r58056436
  
    --- Diff: assets/js/libs/css.escape.js ---
    @@ -1,84 +0,0 @@
    -/*! https://mths.be/cssescape v0.2.1 by @mathias | MIT license */
    -;(function(root) {
    --- End diff --
    
    why is it unneeded?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---