You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/27 04:07:46 UTC
[GitHub] [pulsar-site] tisonkun opened a new pull request, #183: [build][site] cleanup previous content before copy new ones
tisonkun opened a new pull request, #183:
URL: https://github.com/apache/pulsar-site/pull/183
This refers to #175 and resolves https://github.com/apache/pulsar-site/pull/179#issuecomment-1228636515.
I don't know whether or not it causes some regressions I'm unaware of. Please help with reviews @urfreespace @michaeljmarshall @dave2wave
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #183: [build][site] cleanup previous content before copy new ones
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #183:
URL: https://github.com/apache/pulsar-site/pull/183#issuecomment-1229727437
Updated to retain the current logic while removing all content when build all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace commented on a diff in pull request #183: [build][site] cleanup previous content before copy new ones
Posted by GitBox <gi...@apache.org>.
urfreespace commented on code in PR #183:
URL: https://github.com/apache/pulsar-site/pull/183#discussion_r956844911
##########
.github/workflows/ci-pulsar-website-next-build.yaml:
##########
@@ -33,9 +33,9 @@ jobs:
timeout-minutes: 600
steps:
- name: checkout
- uses: actions/checkout@v2
+ uses: actions/checkout@v3
with:
- fetch-depth: 2
+ fetch-depth: 1
Review Comment:
here, we need depth 2, we need to compare the changes of the last 2 commits because we judge which versions of the documents have changed and only build the changed versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #183: [build][site] cleanup previous content before copy new ones
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #183:
URL: https://github.com/apache/pulsar-site/pull/183#discussion_r956845707
##########
site2/tools/publish-website.sh:
##########
@@ -52,11 +51,7 @@ PULSAR_SITE_TMP=/tmp/pulsar-site
mkdir -p $PULSAR_SITE_TMP/content/
fi
- echo "BUILD_ALL:"$BUILD_ALL
- if [[ $BUILD_ALL"" == "11" ]]; then
- echo "clean all the old random js files because a new all version build done, all the js is regenerated with a random name"
- rm -rf $PULSAR_SITE_TMP/content/assets/js
- fi
+ rm -rf $PULSAR_SITE_TMP/content/*
Review Comment:
It seems a full build takes 40 minutes to complete, while we normally build every six hours. Do we really need this improvement?
The current issue is that if we don't remove content, we can have dangling pages even if it's removed on the master branch.
But yes, we can retain the current logic while removing all content when build all :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace commented on a diff in pull request #183: [build][site] cleanup previous content before copy new ones
Posted by GitBox <gi...@apache.org>.
urfreespace commented on code in PR #183:
URL: https://github.com/apache/pulsar-site/pull/183#discussion_r956844216
##########
site2/tools/publish-website.sh:
##########
@@ -52,11 +51,7 @@ PULSAR_SITE_TMP=/tmp/pulsar-site
mkdir -p $PULSAR_SITE_TMP/content/
fi
- echo "BUILD_ALL:"$BUILD_ALL
- if [[ $BUILD_ALL"" == "11" ]]; then
- echo "clean all the old random js files because a new all version build done, all the js is regenerated with a random name"
- rm -rf $PULSAR_SITE_TMP/content/assets/js
- fi
+ rm -rf $PULSAR_SITE_TMP/content/*
Review Comment:
you can't remove all content every time, just when the website has a full build, you can do that, in fact, we just build the versions which have files changes, just once full build(all versions and all languages) one day, so these code can't be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #183: [build][site] cleanup previous content before copy new ones
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #183:
URL: https://github.com/apache/pulsar-site/pull/183#discussion_r956873354
##########
site2/tools/publish-website.sh:
##########
@@ -52,11 +51,7 @@ PULSAR_SITE_TMP=/tmp/pulsar-site
mkdir -p $PULSAR_SITE_TMP/content/
fi
- echo "BUILD_ALL:"$BUILD_ALL
- if [[ $BUILD_ALL"" == "11" ]]; then
- echo "clean all the old random js files because a new all version build done, all the js is regenerated with a random name"
- rm -rf $PULSAR_SITE_TMP/content/assets/js
- fi
+ rm -rf $PULSAR_SITE_TMP/content/*
Review Comment:
Updated.
##########
.github/workflows/ci-pulsar-website-next-build.yaml:
##########
@@ -33,9 +33,9 @@ jobs:
timeout-minutes: 600
steps:
- name: checkout
- uses: actions/checkout@v2
+ uses: actions/checkout@v3
with:
- fetch-depth: 2
+ fetch-depth: 1
Review Comment:
Thanks! Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace merged pull request #183: [build][site] cleanup previous content before copy new ones
Posted by GitBox <gi...@apache.org>.
urfreespace merged PR #183:
URL: https://github.com/apache/pulsar-site/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org