[GitHub] mrutkows commented on a change in pull request #566: Rename manifest and deployment test files to meaningful name

[gi...@git.apache.org]

mrutkows commented on a change in pull request #566: Rename manifest and deployment test files to meaningful name
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/566#discussion_r141700510
 
 

 ##########
 File path: parsers/yamlparser_test.go
 ##########
 @@ -26,14 +26,13 @@ import (
 
 var manifestfile_val_pkg = "../tests/dat/manifest_validate_package_grammar.yaml"
 var manifestfile_val_tar = "../tests/dat/manifest_validate_trigger_action_rule_grammar.yaml"
-var manifestfile3 = "../tests/dat/manifest3.yaml"
-var manifestfile4 = "../tests/dat/manifest4.yaml"
-var manifestfile5 = "../tests/dat/manifest5.yaml"
-var manifestfile6 = "../tests/dat/manifest6.yaml"
+var manifestfile3 = "../tests/dat/manifest_validate_triggerfeed.yaml"
 
 Review comment:
   Can we also rename the variables in the package as well; for example
   
   rename 'manifestfile4' to 'manifestfile_validate_rule' which makes the code below that uses the variable able to conform that the variable does indeed match the test.  
   
   This would be the same comment for manifestfile4 through 6 and testfile3 through 4.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services