You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/09/21 18:56:50 UTC
[GitHub] [parquet-mr] belugabehr opened a new pull request #817: PARQUET-1914: Allow ProtoParquetReader To Support InputFile
belugabehr opened a new pull request #817:
URL: https://github.com/apache/parquet-mr/pull/817
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [PARQUET-1914](https://issues.apache.org/jira/browse/PARQUET-1914) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky merged pull request #817: PARQUET-1914: Allow ProtoParquetReader To Support InputFile
Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #817:
URL: https://github.com/apache/parquet-mr/pull/817
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #817: PARQUET-1914: Allow ProtoParquetReader To Support InputFile
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on a change in pull request #817:
URL: https://github.com/apache/parquet-mr/pull/817#discussion_r510154080
##########
File path: parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoParquetReader.java
##########
@@ -56,7 +61,25 @@ public ProtoParquetReader(Path file) throws IOException {
*/
@Deprecated
@SuppressWarnings("unchecked")
- public ProtoParquetReader(Path file, UnboundRecordFilter recordFilter) throws IOException {
+ public ProtoParquetReader(Path file, UnboundRecordFilter recordFilter)
+ throws IOException {
Review comment:
Untouched code should not be formatted. (BTW, the max line width is 120 characters anyway.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org