[GitHub] [pinot] walterddr commented on a diff in pull request #8926: reduce positioning operation to single operation

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #8926:
URL: https://github.com/apache/pinot/pull/8926#discussion_r902027627


##########
pinot-core/src/main/java/org/apache/pinot/core/common/datablock/BaseDataBlock.java:
##########
@@ -221,7 +221,7 @@ public BaseDataBlock(ByteBuffer byteBuffer)
    * @param colId column ID
    * @return the length to extract from variable size buffer.
    */
-  protected abstract int positionCursorInVariableBuffer(int rowId, int colId);
+  protected abstract int computePositionCursorInVariableBuffer(int rowId, int colId);

Review Comment:
   yeah and return the length to read out of the var-byte buffer. let me rethink the naming



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org