You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/10/12 20:02:13 UTC
[GitHub] [trafficserver] ezelkow1 opened a new pull request, #9138: Change regex to operate on the full pristine URL and not just the path
ezelkow1 opened a new pull request, #9138:
URL: https://github.com/apache/trafficserver/pull/9138
This changes the regex field in the MaxMind plugin to operate on the full original pristine URL (without query strings). This way users can construct their own regexes that can operate on the hostname or the path or both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #9138: MaxMind change regex to operate on the full pristine URL and not just the path
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on PR #9138:
URL: https://github.com/apache/trafficserver/pull/9138#issuecomment-1276721694
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 merged pull request #9138: MaxMind change regex to operate on the full pristine URL and not just the path
Posted by GitBox <gi...@apache.org>.
ezelkow1 merged PR #9138:
URL: https://github.com/apache/trafficserver/pull/9138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9138: MaxMind change regex to operate on the full pristine URL and not just the path
Posted by GitBox <gi...@apache.org>.
cmcfarlen commented on code in PR #9138:
URL: https://github.com/apache/trafficserver/pull/9138#discussion_r994021680
##########
plugins/experimental/maxmind_acl/mmdb.cc:
##########
@@ -670,7 +682,7 @@ Acl::eval_anonymous(MMDB_entry_s *entry)
// allowable country code from our map.
// False otherwise
bool
-Acl::eval_country(MMDB_entry_data_s *entry_data, const char *path, int path_len)
+Acl::eval_country(MMDB_entry_data_s *entry_data, std::string url)
Review Comment:
`const std::string&` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #9138: MaxMind change regex to operate on the full pristine URL and not just the path
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on PR #9138:
URL: https://github.com/apache/trafficserver/pull/9138#issuecomment-1278191763
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org