You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/08/04 12:10:28 UTC

Review Request 24228: CLOUDSTACK-7235: Fixed ModifyStoragePoolCommand returns unsupported command answer if provided wrong path

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24228/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Bugs: CLOUDSTACK-7235
    https://issues.apache.org/jira/browse/CLOUDSTACK-7235


Repository: cloudstack-git


Description
-------

 Now ModifyStoragePoolCommand returns appropriate error if provided wrong path


Diffs
-----

  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 195a964 

Diff: https://reviews.apache.org/r/24228/diff/


Testing
-------

verified by adding the primary storage with wrong path. Appropriate error is returned from the agent


Thanks,

Anshul Gangwar


Re: Review Request 24228: CLOUDSTACK-7235: Fixed ModifyStoragePoolCommand returns unsupported command answer if provided wrong path

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24228/#review50861
-----------------------------------------------------------

Ship it!


Committed in d1796c5f585e79d9f833b414023352e5df84fb03 to asf master

- Devdeep Singh


On Aug. 4, 2014, 10:10 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24228/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 10:10 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-7235
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7235
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  Now ModifyStoragePoolCommand returns appropriate error if provided wrong path
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 195a964 
> 
> Diff: https://reviews.apache.org/r/24228/diff/
> 
> 
> Testing
> -------
> 
> verified by adding the primary storage with wrong path. Appropriate error is returned from the agent
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>