You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/03/11 10:37:56 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #24553: Move classes from pipeline api to core and scenario module
sandynz opened a new pull request, #24553:
URL: https://github.com/apache/shardingsphere/pull/24553
To simplify pipeline-api module.
Changes proposed in this pull request:
- Move migration and consistency check config classes to scenario module
- Move classes from api to core module
- Move yaml classes in core module
- Remove unused class YamlPipelineColumnMetaData
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia merged pull request #24553: Move classes from pipeline api to core and scenario module
Posted by "taojintianxia (via GitHub)" <gi...@apache.org>.
taojintianxia merged PR #24553:
URL: https://github.com/apache/shardingsphere/pull/24553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24553: Move classes from pipeline api to core and scenario module
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24553:
URL: https://github.com/apache/shardingsphere/pull/24553#issuecomment-1464888663
## [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24553](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9da00dc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8a74f1a489ce38678cfd757af166ad2927d59e28?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a74f1a) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9da00dc differs from pull request most recent head 512b611. Consider uploading reports for the commit 512b611 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24553 +/- ##
=========================================
Coverage 50.00% 50.00%
Complexity 1595 1595
=========================================
Files 3312 3311 -1
Lines 54050 54047 -3
Branches 9942 9942
=========================================
Hits 27026 27026
+ Misses 24608 24605 -3
Partials 2416 2416
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dc/core/connector/SocketSinkImporterConnector.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvY29ubmVjdG9yL1NvY2tldFNpbmtJbXBvcnRlckNvbm5lY3Rvci5qYXZh) | `15.55% <ø> (ø)` | |
| [...pipeline/cdc/core/importer/SocketSinkImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvaW1wb3J0ZXIvU29ja2V0U2lua0ltcG9ydGVyLmphdmE=) | `21.05% <ø> (ø)` | |
| [...e/cdc/core/importer/SocketSinkImporterCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvaW1wb3J0ZXIvU29ja2V0U2lua0ltcG9ydGVyQ3JlYXRvci5qYXZh) | `100.00% <ø> (ø)` | |
| [...k/consistency/DataConsistencyCheckIgnoredType.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9hcGkvY2hlY2svY29uc2lzdGVuY3kvRGF0YUNvbnNpc3RlbmN5Q2hlY2tJZ25vcmVkVHlwZS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../check/consistency/DataConsistencyCheckResult.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9hcGkvY2hlY2svY29uc2lzdGVuY3kvRGF0YUNvbnNpc3RlbmN5Q2hlY2tSZXN1bHQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...k/consistency/DataConsistencyCountCheckResult.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9hcGkvY2hlY2svY29uc2lzdGVuY3kvRGF0YUNvbnNpc3RlbmN5Q291bnRDaGVja1Jlc3VsdC5qYXZh) | `0.00% <ø> (ø)` | |
| [...nsistency/yaml/YamlDataConsistencyCheckResult.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9hcGkvY2hlY2svY29uc2lzdGVuY3kveWFtbC9ZYW1sRGF0YUNvbnNpc3RlbmN5Q2hlY2tSZXN1bHQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...cy/yaml/YamlDataConsistencyCheckResultSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9hcGkvY2hlY2svY29uc2lzdGVuY3kveWFtbC9ZYW1sRGF0YUNvbnNpc3RlbmN5Q2hlY2tSZXN1bHRTd2FwcGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ata/pipeline/api/config/ImporterConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9hcGkvY29uZmlnL0ltcG9ydGVyQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...process/yaml/YamlPipelineProcessConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9hcGkvY29uZmlnL3Byb2Nlc3MveWFtbC9ZYW1sUGlwZWxpbmVQcm9jZXNzQ29uZmlndXJhdGlvbi5qYXZh) | `4.00% <ø> (ø)` | |
| ... and [47 more](https://codecov.io/gh/apache/shardingsphere/pull/24553?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org