You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Szilard Nemeth (Jira)" <ji...@apache.org> on 2021/09/14 14:46:00 UTC
[jira] [Commented] (YARN-10920) Created a dedicated class for Node
Labels
[ https://issues.apache.org/jira/browse/YARN-10920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414979#comment-17414979 ]
Szilard Nemeth commented on YARN-10920:
---------------------------------------
This is one hell of an effort.
1. First, I need to understand the current domain objects. There's a [NodeLabel class|https://github.com/apache/hadoop/blob/95372657fc25c02399b01793833021ccf88dada2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeLabel.java#L29] from the yarn-api project.
2. Second, I also have a [ConfiguredNodeLabels class|https://github.com/apache/hadoop/blob/0934e783cf687eee4f5f23e65500b91d18b96f65/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ConfiguredNodeLabels.java#L36] in the hadoop-yarn-server-resourcemanager project.
3. The rest of the node labels are simple strings so they are quite hard to track.
I need to understand and have a full picture of how these classes are being used and what are their client objects and come up with a clean solution.
> Created a dedicated class for Node Labels
> -----------------------------------------
>
> Key: YARN-10920
> URL: https://issues.apache.org/jira/browse/YARN-10920
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
>
> In the current codebase, Node labels are simple strings. It's very error-prone to use Strings as it can contain basically anything. Moreover, it's easier to keep track of all usages if we have a dedicated class for Node labels.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org