You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2019/11/21 16:04:37 UTC
svn commit: r1870096 - in /poi/trunk/src:
excelant/testcases/org/apache/poi/ss/excelant/BuildFileTest.java
testcases/org/apache/poi/ss/formula/functions/TestNpv.java
Author: fanningpj
Date: Thu Nov 21 16:04:37 2019
New Revision: 1870096
URL: http://svn.apache.org/viewvc?rev=1870096&view=rev
Log:
replace some more StringBuffers
Modified:
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/BuildFileTest.java
poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/BuildFileTest.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/BuildFileTest.java?rev=1870096&r1=1870095&r2=1870096&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/BuildFileTest.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/BuildFileTest.java Thu Nov 21 16:04:37 2019
@@ -48,10 +48,10 @@ public abstract class BuildFileTest exte
protected Project project;
- private StringBuffer logBuffer;
- private StringBuffer fullLogBuffer;
- private StringBuffer outBuffer;
- private StringBuffer errBuffer;
+ private StringBuilder logBuffer;
+ private StringBuilder fullLogBuffer;
+ private StringBuilder outBuffer;
+ private StringBuilder errBuffer;
private BuildException buildException;
/**
@@ -265,8 +265,8 @@ public abstract class BuildFileTest exte
return buildException;
}
- private String cleanBuffer(StringBuffer buffer) {
- StringBuffer cleanedBuffer = new StringBuffer();
+ private String cleanBuffer(StringBuilder buffer) {
+ StringBuilder cleanedBuffer = new StringBuilder();
for (int i = 0; i < buffer.length(); i++) {
char ch = buffer.charAt(i);
if (ch != '\r') {
@@ -292,8 +292,8 @@ public abstract class BuildFileTest exte
*/
public void configureProject(String filename, int logLevel)
throws BuildException {
- logBuffer = new StringBuffer();
- fullLogBuffer = new StringBuffer();
+ logBuffer = new StringBuilder();
+ fullLogBuffer = new StringBuilder();
project = new Project();
project.init();
project.setNewProperty("data.dir.name", getDataDir());
@@ -315,14 +315,14 @@ public abstract class BuildFileTest exte
try {
sysOut.flush();
sysErr.flush();
- outBuffer = new StringBuffer();
+ outBuffer = new StringBuilder();
PrintStream out = new PrintStream(new AntOutputStream(outBuffer));
System.setOut(out);
- errBuffer = new StringBuffer();
+ errBuffer = new StringBuilder();
PrintStream err = new PrintStream(new AntOutputStream(errBuffer));
System.setErr(err);
- logBuffer = new StringBuffer();
- fullLogBuffer = new StringBuffer();
+ logBuffer = new StringBuilder();
+ fullLogBuffer = new StringBuilder();
buildException = null;
project.executeTarget(targetName);
} finally {
@@ -483,9 +483,9 @@ public abstract class BuildFileTest exte
* an output stream which saves stuff to our buffer.
*/
protected static class AntOutputStream extends java.io.OutputStream {
- private StringBuffer buffer;
+ private StringBuilder buffer;
- public AntOutputStream(StringBuffer buffer) {
+ public AntOutputStream(StringBuilder buffer) {
this.buffer = buffer;
}
Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java?rev=1870096&r1=1870095&r2=1870096&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java Thu Nov 21 16:04:37 2019
@@ -71,7 +71,7 @@ public final class TestNpv extends TestC
HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("IrrNpvTestCaseData.xls");
HSSFSheet sheet = wb.getSheet("IRR-NPV");
HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb);
- StringBuffer failures = new StringBuffer();
+ StringBuilder failures = new StringBuilder();
int failureCount = 0;
// TODO YK: Formulas in rows 16 and 17 operate with ArrayPtg which isn't yet supported
// FormulaEvaluator as of r1041407 throws "Unexpected ptg class (org.apache.poi.ss.formula.ptg.ArrayPtg)"
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org