You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/26 06:42:41 UTC

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1674: feat: improved plugin #1631

iamayushdas opened a new pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
     ## Plugin TODO
    * [ ]  Search area, using Table's own, using fuzzy search.
    * [x]  page title not internationalized: configure global plugins/Configure Global Plugin.
    * [ ]  Add icon for Plugin Marketplace plugins.
    * [x]  list page top title, add description: list of enabled plugins.
    * [x]  list page, edit button in action area modified to: `配置/Configure`.
    
    ## Plugin Editor
    * [ ]  Some Auth plugins do not need to be configured, in the Data Editor, to disable the input of content.
    * [x]  The button is not internationalized.
    * [ ]  Document button fits too close to JSON button.
    * [ ]  JSONSchema checks for error messages, which can be divided into: error message + view details.
    * [ ]  CodeMirror code error highlighting.
    
    ## Meta Raw data editor (Route List page)
    * [ ]  Button not internationalized.
    * [ ]  layout needs to be adjusted, with additional scrolling axes.
   
   Extras: Dashboard title also internationalised
   
   **Related issues**
   
   fix/resolve #1631 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   
   ![screencapture-172-20-10-3-8000-plugin-list-2021-03-26-08_32_08](https://user-images.githubusercontent.com/40708551/112571312-d12c6a00-8e0d-11eb-9881-691a9eb59334.png)
   
   ![screencapture-172-20-10-3-8000-plugin-list-2021-03-26-08_19_00](https://user-images.githubusercontent.com/40708551/112571368-e43f3a00-8e0d-11eb-9f63-69a9c0b2caf1.png)
   
   ![screencapture-172-20-10-3-8000-plugin-list-2021-03-26-08_33_35](https://user-images.githubusercontent.com/40708551/112571430-020c9f00-8e0e-11eb-81d1-e03f3de60fd5.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808227126


   Just review & comment if needed :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-811959266


   @juzhiyuan all approvals are done now, you can merge it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808250598


   got it, please be patient for GitHub is not realtime always :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808229264


   > @iamayushdas of course! Everyone could review PRs in our community :)
   
   I meant ,Can you review this for approval


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808081783


   > @nic-chen @starsz Plz take a look at the failed CI.
   
   It may be because apisix-docker failed to start.
   This problem has been fixed:
   https://github.com/apache/apisix-docker/pull/154
   
   I ran again to take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-807985515


   @nic-chen @starsz Plz take a look at the failed CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#discussion_r604545716



##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',

Review comment:
       idk i guess there is some commit issue. :confused:




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-810740633


   Hi, @LiteSun @Jaycean @liuxiran @bzp2010 Please view this one first, once that gets merged, @iamayushdas Please update this branch to latest.
   
   https://github.com/apache/apisix-dashboard/pull/1685


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
Jaycean commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-811568946


   @iamayushdas  Please update the branch to resolve the code conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808226909


   @iamayushdas of course! Everyone could review PRs in our community :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-809929827


   @liuxiran please review this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#discussion_r604545716



##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',

Review comment:
       idk i guess there is some commit issue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808124365


   @nic-chen @juzhiyuan @LiteSun @guoqqqi  can i have the review please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#discussion_r604577042



##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',

Review comment:
       Yes yes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808124365


   @nic-chen @juzhiyuan can i have the review please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#discussion_r604576644



##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',

Review comment:
       haha, let's review one by one  currently.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808846002


   > @nic-chen @juzhiyuan @LiteSun @guoqqqi can i have the review please?
   
   sorry, I am not familiar with the front-end codes and can't review it for you
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1674: feat: improved plugin #1631

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1674:
URL: https://github.com/apache/apisix-dashboard/pull/1674#discussion_r603816546



##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',

Review comment:
       I remember I have reviewed one PR like this 😳 Why will I see it again?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org