You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2021/06/29 09:05:18 UTC
[kudu-CR] [tools] KUDU-1884 Add custom SASL protocol name for some CLI tools
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17641
Change subject: [tools] KUDU-1884 Add custom SASL protocol name for some CLI tools
......................................................................
[tools] KUDU-1884 Add custom SASL protocol name for some CLI tools
This patch adds support to set a custom SASL protocol name
when using LeaderMasterProxy in kudu CLI tools.
Change-Id: If2163984fc0b144ee7ab11f2f928750925f4beeb
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_common.cc
2 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/17641/1
--
To view, visit http://gerrit.cloudera.org:8080/17641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2163984fc0b144ee7ab11f2f928750925f4beeb
Gerrit-Change-Number: 17641
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] [tools] KUDU-1884 Add custom SASL protocol name for some CLI tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17641 )
Change subject: [tools] KUDU-1884 Add custom SASL protocol name for some CLI tools
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Thank you for the fix!
http://gerrit.cloudera.org:8080/#/c/17641/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17641/1//COMMIT_MSG@10
PS1, Line 10: when using LeaderMasterProxy
Nice catch!
--
To view, visit http://gerrit.cloudera.org:8080/17641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2163984fc0b144ee7ab11f2f928750925f4beeb
Gerrit-Change-Number: 17641
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Jul 2021 01:14:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] KUDU-1884 Add custom SASL protocol name for some CLI tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17641 )
Change subject: [tools] KUDU-1884 Add custom SASL protocol name for some CLI tools
......................................................................
[tools] KUDU-1884 Add custom SASL protocol name for some CLI tools
This patch adds support to set a custom SASL protocol name
when using LeaderMasterProxy in kudu CLI tools.
Change-Id: If2163984fc0b144ee7ab11f2f928750925f4beeb
Reviewed-on: http://gerrit.cloudera.org:8080/17641
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_common.cc
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If2163984fc0b144ee7ab11f2f928750925f4beeb
Gerrit-Change-Number: 17641
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)