You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/01/03 14:08:00 UTC

[GitHub] [commons-lang] garydgregory commented on a change in pull request #688: [LANG-1637] Fix 2 digit week year formatting

garydgregory commented on a change in pull request #688:
URL: https://github.com/apache/commons-lang/pull/688#discussion_r551010473



##########
File path: src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
##########
@@ -1118,7 +1118,7 @@ public void appendTo(final Appendable buffer, final Calendar calendar) throws IO
          */
         @Override
         public final void appendTo(final Appendable buffer, final int value) throws IOException {
-            appendDigits(buffer, value);
+            appendDigits(buffer, value % 100);

Review comment:
       Hi @michael-o 
   Earlier you said "I am not convinced by this because it patches the wrong spot." implying there was a "right" spot, but where would that be?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org