You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/08/30 16:36:46 UTC
[PR] Merge 8.1.x into 9.0.x [grails-core]
jamesfredley opened a new pull request, #16277:
URL: https://github.com/apache/grails-core/pull/16277
## Description
Merge current `8.1.x` (including the `8.0.x` line from #16276) into `9.0.x`.
This brings the Forge Gradle 9 Shadow `8.3.11` pin and other already-landed 8.0/8.1 work onto the Groovy 6 line.
Conflict handling kept 9.0-specific Groovy 6 pins and the functional hanging-cell CI workaround, while restoring 8.1 CAS/Neo4j jobs, MongoDB driver-family BOM constraints, and the Neo4j BOM custom versions.
Local Forge validation from `grails-forge/`:
- `:grails-forge-web-netty:shadowDistTar` and `:grails-forge-web-netty:awsElasticBeanstalk` succeeded
- AWS zip contains `app.jar`, `Procfile`, `start.sh`, and `.platform/nginx/conf.d/proxy.conf`
- Nested `Main-Class: org.grails.forge.netty.Application`
## Contributor Checklist
### Issue and Scope
- [ ] This PR is linked to an existing issue that has been **acknowledged or approved** by the project team. If no approved issue exists, please give background on why this change is necessary. Tickets are preferred for release change log history.
- [x] This PR addresses the **complete scope** of the linked issue. Partial implementations or unfinished work should not be submitted for review.
- [x] This PR contains a **single, focused change**. Unrelated changes should be submitted as separate pull requests.
- [x] This PR targets the **correct branch** for the type of change:
- **Patch release branches** (e.g., `7.0.x`): Bug fixes only. No new features or API changes.
- **Minor release branches** (e.g., `7.1.x`): New features are welcome, but breaking existing APIs must be avoided.
- **Major release branches** (e.g., `8.0.x`): Reserved for major changes. Breaking API changes are permitted.
### Code Quality
- [x] I have **added or updated tests** that cover the changes introduced in this PR. All code contributions are expected to include appropriate test coverage.
- [ ] I have verified that all existing tests pass by running `./gradlew build --rerun-tasks`.
- [x] My code follows the project's **code style** guidelines. I have run `./gradlew codeStyle` and resolved any violations. See [Code Style](../CONTRIBUTING.md#code-style) for details.
- [x] This PR does **not** include mass reformatting, style-only changes, or large-scale refactoring unless it was **explicitly approved** in the linked issue. Unsolicited reformatting will not be accepted.
- [x] If generative AI tooling was used in preparing this contribution, a quality model was used to ensure contributions are **consistent with the project's quality standards**.
### Licensing and Attribution
- [x] All contributed code is provided under the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0), and new source files include the appropriate **Apache license header**.
- [x] I have the necessary rights to submit this contribution and confirm it is my own original work (see [Legal Notice](../CONTRIBUTING.md#i-want-to-contribute)).
- [x] If generative AI tooling was used in preparing this contribution, I have followed the [Apache Software Foundation's policy on generative tooling](https://www.apache.org/legal/generative-tooling.html) and have properly attributed its use.
### Documentation
- [x] If this PR introduces user-facing changes, I have included or updated the relevant documentation.
- [x] If this PR adds a new feature, I have updated the **What's New** section of the Grails Guide.
- [x] If this PR introduces breaking changes or changes that require user action during an upgrade, I have updated the **Upgrade Notes** for the corresponding version in the Grails Guide.
- [x] The PR description clearly explains **what** was changed and **why**.
Generative AI (Cursor Grok 4.6) was used to complete the merge, resolve conflicts, and run validation. Oracle reviewed the shipping diff as GREEN; Codex found no blocking regressions in the conflict resolutions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge 8.1.x into 9.0.x [grails-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16277:
URL: https://github.com/apache/grails-core/pull/16277#issuecomment-5470028399
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16277?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 30.1329%. Comparing base ([`1ad4efe`](https://app.codecov.io/gh/apache/grails-core/commit/1ad4efe06c9193b022fa9c2bd28ab27a481d31a9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8c47f15`](https://app.codecov.io/gh/apache/grails-core/commit/8c47f15623308a378501d2237a7335e8298b221a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/grails-core/pull/16277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 9.0.x #16277 +/- ##
===================================================
- Coverage 53.1045% 30.1329% -22.9715%
+ Complexity 19363 517 -18846
===================================================
Files 2081 81 -2000
Lines 99018 4739 -94279
Branches 17375 817 -16558
===================================================
- Hits 52583 1428 -51155
+ Misses 38875 3068 -35807
+ Partials 7560 243 -7317
```
[see 2036 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16277/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge 8.1.x into 9.0.x [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #16277:
URL: https://github.com/apache/grails-core/pull/16277#issuecomment-5527256696
This was already complete external to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge 8.1.x into 9.0.x [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley closed pull request #16277: Merge 8.1.x into 9.0.x
URL: https://github.com/apache/grails-core/pull/16277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge 8.1.x into 9.0.x [grails-core]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #16277:
URL: https://github.com/apache/grails-core/pull/16277#discussion_r3889935827
##########
grails-quartz/src/main/templates/Job.groovy:
##########
@@ -0,0 +1,11 @@
+package ${packageName}
+
+class ${className}Job {
+ static triggers = {
+ simple repeatInterval: 5000l // execute job once in 5 seconds
+ }
Review Comment:
Use an uppercase `L` for the long literal and align indentation with the rest of the template. Lowercase `l` is easy to misread and differs from the Quartz docs in this repo (which use `5000L`).
##########
grails-test-examples/neo4j/test-data-service/grails-app/services/example/StudentService.groovy:
##########
@@ -21,6 +21,7 @@ package example
import grails.gorm.services.Service
import grails.gorm.transactions.Transactional
+import org.springframework.beans.factory.annotation.Autowired
Review Comment:
Unused import: Autowired is imported but not referenced anywhere in this service. Leaving it in can trigger style/analysis failures and makes the example harder to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge 8.1.x into 9.0.x [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16277:
URL: https://github.com/apache/grails-core/pull/16277#issuecomment-5470143505
## ✅ All tests passed ✅
🏷️ Commit: 8c47f15623308a378501d2237a7335e8298b221a
▶️ Tests: 33610 executed
⚪️ Checks: 87/87 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org