You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2023/04/28 10:25:47 UTC

[GitHub] [camel-k] squakez opened a new pull request, #4300: fix(operator): do not panic if cannot set GOMAXPROCS

squakez opened a new pull request, #4300:
URL: https://github.com/apache/camel-k/pull/4300

   Closes #4299
   
   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   fix(operator): do not panic if cannot set GOMAXPROCS
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] astefanutti commented on pull request #4300: fix(operator): do not panic if cannot set GOMAXPROCS

Posted by "astefanutti (via GitHub)" <gi...@apache.org>.
astefanutti commented on PR #4300:
URL: https://github.com/apache/camel-k/pull/4300#issuecomment-1539854866

   > @astefanutti I'd like your opinion on this one. I have the feeling we should be safe by just logging the error (then it will be up to the operator installer to figure it out how to solve this problem to improve concurrency). In this way we at least let the operator run in situations where we cannot control the cluster (ie, the github actions which suddenly stopped to work).
   
   @squakez sorry for the late reply, this felt under my radar. Error logging looks like a pragmatic approach. I think situations where this could lead to nasty issues are very seldom. This would ideally go away anyway with golang/go#33803.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #4300: fix(operator): do not panic if cannot set GOMAXPROCS

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4300:
URL: https://github.com/apache/camel-k/pull/4300#issuecomment-1527615307

   Merging, so that we can keep the development and other PRs ahead. We can keep discussing in #4299 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez merged pull request #4300: fix(operator): do not panic if cannot set GOMAXPROCS

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4300:
URL: https://github.com/apache/camel-k/pull/4300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] gansheer commented on a diff in pull request #4300: fix(operator): do not panic if cannot set GOMAXPROCS

Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #4300:
URL: https://github.com/apache/camel-k/pull/4300#discussion_r1180344830


##########
script/Makefile:
##########
@@ -86,7 +86,7 @@ STAGING_RUNTIME_REPO :=
 INSTALL_DEFAULT_KAMELETS ?= true
 KAMELET_CATALOG_REPO := https://github.com/apache/camel-kamelets.git
 # Make sure to use a released tag or empty if you want to get the latest development bits
-KAMELET_CATALOG_REPO_TAG := 
+KAMELET_CATALOG_REPO_TAG := v3.20.1.1

Review Comment:
   Just curious : why do we need it when we didn't before ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on a diff in pull request #4300: fix(operator): do not panic if cannot set GOMAXPROCS

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4300:
URL: https://github.com/apache/camel-k/pull/4300#discussion_r1180357240


##########
script/Makefile:
##########
@@ -86,7 +86,7 @@ STAGING_RUNTIME_REPO :=
 INSTALL_DEFAULT_KAMELETS ?= true
 KAMELET_CATALOG_REPO := https://github.com/apache/camel-kamelets.git
 # Make sure to use a released tag or empty if you want to get the latest development bits
-KAMELET_CATALOG_REPO_TAG := 
+KAMELET_CATALOG_REPO_TAG := v3.20.1.1

Review Comment:
   this is unrelated, I merged some other change which removed that configuration by mistake. The important part of the PR is 2e50f84f05a43c79754e2fcbef5b26f9732c3de8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #4300: fix(operator): do not panic if cannot set GOMAXPROCS

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4300:
URL: https://github.com/apache/camel-k/pull/4300#issuecomment-1527343274

   @astefanutti I'd like your opinion on this one. I have the feeling we should be safe by just logging the error (then it will be up to the operator installer to figure it out how to solve this problem to improve concurrency). In this way we at least let the operator run in situations where we cannot control the cluster (ie, the github actions which suddenly stopped to work).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org