[GitHub] [incubator-brpc] songdongsheng commented on issue #1693: compile failed with error "error: macro "__has_attribute" requires an identifier"

[GitBox <gi...@apache.org>]

songdongsheng commented on issue #1693:
URL: https://github.com/apache/incubator-brpc/issues/1693#issuecomment-1137629449

   在使用 brpc 的代码中，全面关闭 **const** 优化是极为不负责任的做法，这么粗暴的绕过问题，会让人对 brpc 的代码质量产生疑虑，阻碍 brpc 的推广。
   
   1. 如果 brpc 认为 glibc  做得不对，可以给它报告 bug，说明理由。
   2. 作为一个临时方案，定义一个 bthread_errno() 或 brpc_errno()，比简单粗暴的禁止 **const** 优化优雅，也易于让人接受。
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org