[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7249: NIFI-11547: Fix DBCPConnectionPool verification

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory commented on code in PR #7249:
URL: https://github.com/apache/nifi/pull/7249#discussion_r1194371642


##########
nifi-nar-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/AbstractDBCPConnectionPool.java:
##########
@@ -157,7 +157,7 @@ private void loginKerberos(KerberosUser kerberosUser) throws InitializationExcep
 
     protected abstract DataSourceConfiguration getDataSourceConfiguration(final ConfigurationContext context);
 
-    protected void configureDataSource(final ConfigurationContext context, final DataSourceConfiguration configuration) {
+    protected void configureDataSource(final ConfigurationContext context, final BasicDataSource dataSource, final DataSourceConfiguration configuration) {

Review Comment:
   Naming this variable `dataSource` shadows the protected member variable, so the property name should be changed for clarity.



##########
nifi-nar-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/AbstractDBCPConnectionPool.java:
##########
@@ -79,7 +79,7 @@ public List<ConfigVerificationResult> verify(final ConfigurationContext context,
         final BasicDataSource dataSource = new BasicDataSource();

Review Comment:
   This variable name shadows the protected member variable name, so it would be helpful to rename the variable in this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org