You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/19 08:13:18 UTC
[GitHub] [airflow] StevenReitsma commented on a change in pull request
#5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators
StevenReitsma commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators
URL: https://github.com/apache/airflow/pull/5645#discussion_r315085983
##########
File path: airflow/contrib/hooks/sagemaker_hook.py
##########
@@ -232,15 +234,20 @@ def get_conn(self):
def get_log_conn(self):
"""
- Establish an AWS connection for retrieving logs during training
+ This method is deprecated. Please use `airflow.contrib.hooks.AwsLogsHook.get_conn` instead.
Review comment:
I'm actually referencing a method in another module so I changed it to
```
:py:meth:`airflow.contrib.hooks.AwsLogsHook.get_conn`
```
Is that the correct way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services