You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2025/12/07 07:08:19 UTC

[PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

voonhous opened a new pull request, #17509:
URL: https://github.com/apache/hudi/pull/17509

   ### Describe the issue this Pull Request addresses
   
   Employing IntelliJ's IDE inspection to swap out boilerplate getters and setters after #17500 was landed.
   
   Caveats:
   
   Some fields were excluded from this refactoring because the IDE inspection silently ignores cases where a direct swap to Lombok is unsafe or semantically different. These manual getters were retained to preserve the existing API contract.
   
   **1. Type Mismatches (Wrapper vs. Primitive)**
   Lombok generates getters with the exact return type of the field. Fields defined as Object Wrappers (e.g., `Integer`) but exposed via the public API as Primitives (e.g., `int`) cannot be converted without breaking the method signature.
   
   | Field Definition (Wrapper) | Existing Manual Getter (Primitive) | What Lombok Would Generate |
   | :--- | :--- | :--- |
   | `private final Long id;` | `public long getId()` | `public Long getId()` |
   | `private final Integer size;` | `public int getSize()` | `public Integer getSize()` |
   
   **2. Annotation Preservation**
   Methods annotated with specific metadata (e.g., `@Nullable`, `@VisibleForTesting`) are skipped by the automated tool. Replacing these with a standard `@Getter` would result in the loss of these annotations on the generated method, potentially affecting static analysis or runtime behavior.
   
   ### Summary and Changelog
   
   Refactored code to reduce boilerplate by utilizing Lombok annotations where safe to do so.
   
   - **Refactoring:** Replaced standard manual getters/setters with Lombok `@Getter`/`@Setter` annotations across eligible classes.
   - **Exclusions:** Retained manual methods for fields involving Wrapper-to-Primitive conversions or specific method-level annotations (as detailed in caveats).
   
   ### Impact
   
   **Refactoring only.** There are no changes to the public API signatures, return types, or runtime behavior. The exclusions ensure strict binary compatibility is maintained.
   
   With this change, we were able to remove a total of approximately 1.2k lines of boilerplate code across approximately 130 files. 
   
   ### Risk Level
   
   **Low**
   
   The changes are strictly syntactic sugar using standard Lombok annotations. Cases that would alter API signatures (Wrapper vs Primitive) or lose metadata (Annotations) were identified and excluded.
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621940702

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6e5e69798f1585a46a797ef2d02a2525bd8d38bb Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979) 
   * 1421b3e415f21ab8169b0f2e61fca5e9cbd3b266 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622799262

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985",
       "triggerID" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9986",
       "triggerID" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   * 79e7c3cde3c51d36ab855321a6106ba85b8981f3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985) 
   * a2127ef584e589abd4c18c128477d3015e542b4a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9986) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3625730189

   @yihua 
   
   > On 1. Type Mismatches (Wrapper vs. Primitive): shall we always use the primitive type?
   Sure, will fix this in a separate PR!
   
   
   > On 2. Annotation Preservation, Lombok support @Getter(onMethod_={@AnnotationsGohere}) // note the underscore after onMethod. (https://projectlombok.org/api/lombok/Getter#onMethod()). Does that work?
   Yeap, this works! I am already doing this for access level changes.
   
   > Thanks for the clean-up. In the future, let's put out smaller PRs so it's easier for the reviewer to make incremental progress on the reviews.
   
   I'll close this PR and split this PR into a module level. Will that work? 
   i.e. There will be a clean up for each PR where i will be swapping cleaning up:
   1. getter
   2. setters
   3. noargs constructor
   4. allargs constructor
   
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622506142

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2cc8a0302c94846bd62ecf80db2bf16504b39052 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982) 
   * 7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983) 
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   * 79e7c3cde3c51d36ab855321a6106ba85b8981f3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622272427

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1421b3e415f21ab8169b0f2e61fca5e9cbd3b266 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980) 
   * 2cc8a0302c94846bd62ecf80db2bf16504b39052 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621763956

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e049bc50fa241ba126b509ae2f493d21e98a2f1 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621904160

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6e5e69798f1585a46a797ef2d02a2525bd8d38bb Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621901389

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98eb8d0096b1e7e63be43fb0facf70680ad65579 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976) 
   * 6e5e69798f1585a46a797ef2d02a2525bd8d38bb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622528039

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985",
       "triggerID" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2cc8a0302c94846bd62ecf80db2bf16504b39052 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982) 
   * 7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983) 
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   * 79e7c3cde3c51d36ab855321a6106ba85b8981f3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985) 
   * a2127ef584e589abd4c18c128477d3015e542b4a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous closed pull request #17509: refactor: Swap out getter and setter methods for Lombok annotations
URL: https://github.com/apache/hudi/pull/17509


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3629953225

   Closing this in favour of module level changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3625079951

   On `1. Type Mismatches (Wrapper vs. Primitive)`: shall we always use the primitive type?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622675577

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985",
       "triggerID" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9986",
       "triggerID" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983) 
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   * 79e7c3cde3c51d36ab855321a6106ba85b8981f3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985) 
   * a2127ef584e589abd4c18c128477d3015e542b4a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9986) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622318130

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1421b3e415f21ab8169b0f2e61fca5e9cbd3b266 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980) 
   * 2cc8a0302c94846bd62ecf80db2bf16504b39052 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982) 
   * 7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3624810558

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985",
       "triggerID" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9986",
       "triggerID" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a99d5dfb5dc6d07e90311346c3ae2d260892b2da",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10002",
       "triggerID" : "a99d5dfb5dc6d07e90311346c3ae2d260892b2da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   * a2127ef584e589abd4c18c128477d3015e542b4a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9986) 
   * a99d5dfb5dc6d07e90311346c3ae2d260892b2da Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10002) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622270300

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1421b3e415f21ab8169b0f2e61fca5e9cbd3b266 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980) 
   * 2cc8a0302c94846bd62ecf80db2bf16504b39052 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621861626

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98eb8d0096b1e7e63be43fb0facf70680ad65579 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622489823

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2cc8a0302c94846bd62ecf80db2bf16504b39052 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982) 
   * 7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983) 
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622062857

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1421b3e415f21ab8169b0f2e61fca5e9cbd3b266 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621902798

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98eb8d0096b1e7e63be43fb0facf70680ad65579 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976) 
   * 6e5e69798f1585a46a797ef2d02a2525bd8d38bb Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #17509:
URL: https://github.com/apache/hudi/pull/17509#discussion_r2596221789


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -1240,7 +1220,7 @@ private void clearMetadataTablePartitionsConfig(Option<MetadataPartitionType> pa
     }
   }
 
-  public HoodieTableMetadata getMetadataTable() {
+  public HoodieTableMetadata getTableMetadata() {

Review Comment:
   Making a slight adjustment here as Lombok's getter annotation for the field `isMetadataTable` is clashing with this method.
   
   Refactoring to make the naming more consistent with it's class type and also to avoid the clashing. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622558923

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985",
       "triggerID" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983) 
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   * 79e7c3cde3c51d36ab855321a6106ba85b8981f3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985) 
   * a2127ef584e589abd4c18c128477d3015e542b4a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622432401

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2cc8a0302c94846bd62ecf80db2bf16504b39052 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982) 
   * 7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983) 
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622510477

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985",
       "triggerID" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2cc8a0302c94846bd62ecf80db2bf16504b39052 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982) 
   * 7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983) 
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   * 79e7c3cde3c51d36ab855321a6106ba85b8981f3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #17509:
URL: https://github.com/apache/hudi/pull/17509#discussion_r2596438140


##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/HoodieParquetConfig.java:
##########
@@ -55,8 +49,4 @@ public HoodieParquetConfig(T writeSupport, CompressionCodecName compressionCodec
     this.compressionRatio = compressionRatio;
     this.dictionaryEnabled = dictionaryEnabled;
   }
-
-  public boolean dictionaryEnabled() {

Review Comment:
   Removing this and using @Getter will change the method signature from `dictionaryEnabled` to `isDictionaryEnabled`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621777724

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e049bc50fa241ba126b509ae2f493d21e98a2f1 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974) 
   * 98eb8d0096b1e7e63be43fb0facf70680ad65579 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3625064375

   > @yihua Can you please help to review this? Thank you!
   
   Thanks for the clean-up.  In the future, let's put out smaller PRs so it's easier for the reviewer to make incremental progress on the reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3625047193

   @yihua Can you please help to review this? Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3625241979

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985",
       "triggerID" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9986",
       "triggerID" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a99d5dfb5dc6d07e90311346c3ae2d260892b2da",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10002",
       "triggerID" : "a99d5dfb5dc6d07e90311346c3ae2d260892b2da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   * a99d5dfb5dc6d07e90311346c3ae2d260892b2da Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10002) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621808009

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e049bc50fa241ba126b509ae2f493d21e98a2f1 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974) 
   * 98eb8d0096b1e7e63be43fb0facf70680ad65579 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3625105555

   On `2. Annotation Preservation`, Lombok support `@Getter(onMethod_={@AnnotationsGohere}) // note the underscore after onMethod.` (https://projectlombok.org/api/lombok/Getter#onMethod()).  Does that work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3625110135

   > On `1. Type Mismatches (Wrapper vs. Primitive)`: shall we always use the primitive type?
   
   This fix can go in a separate PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621928693

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6e5e69798f1585a46a797ef2d02a2525bd8d38bb Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979) 
   * 1421b3e415f21ab8169b0f2e61fca5e9cbd3b266 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3624693065

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     }, {
       "hash" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "90c07b987eef3a1407a8611b2121929b86d6bfdd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9985",
       "triggerID" : "79e7c3cde3c51d36ab855321a6106ba85b8981f3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9986",
       "triggerID" : "a2127ef584e589abd4c18c128477d3015e542b4a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a99d5dfb5dc6d07e90311346c3ae2d260892b2da",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a99d5dfb5dc6d07e90311346c3ae2d260892b2da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   * 90c07b987eef3a1407a8611b2121929b86d6bfdd UNKNOWN
   * a2127ef584e589abd4c18c128477d3015e542b4a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9986) 
   * a99d5dfb5dc6d07e90311346c3ae2d260892b2da UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3621760180

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e049bc50fa241ba126b509ae2f493d21e98a2f1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: Swap out getter and setter methods for Lombok annotations [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17509:
URL: https://github.com/apache/hudi/pull/17509#issuecomment-3622344038

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9974",
       "triggerID" : "7e049bc50fa241ba126b509ae2f493d21e98a2f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9976",
       "triggerID" : "98eb8d0096b1e7e63be43fb0facf70680ad65579",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9979",
       "triggerID" : "6e5e69798f1585a46a797ef2d02a2525bd8d38bb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980",
       "triggerID" : "1421b3e415f21ab8169b0f2e61fca5e9cbd3b266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982",
       "triggerID" : "2cc8a0302c94846bd62ecf80db2bf16504b39052",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983",
       "triggerID" : "7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090d44429c4d192edb6f148ef1321b4809a1be95",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1421b3e415f21ab8169b0f2e61fca5e9cbd3b266 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9980) 
   * 2cc8a0302c94846bd62ecf80db2bf16504b39052 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9982) 
   * 7e4e9f24fb73f2a2f3cdaef745fc0af0c0336ba2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9983) 
   * 090d44429c4d192edb6f148ef1321b4809a1be95 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org