[jira] [Resolved] (SPARK-10133) loadLibSVMFile fails to detect zero-based lines

["Sean Owen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen resolved SPARK-10133.
-------------------------------
    Resolution: Not A Problem

No, because the indices have already had 1 subtracted from them.
https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala#L82

I'm sure about this since I also made the same mistake when reviewing this change, enough that I'm provisionally closing this.

> loadLibSVMFile fails to detect zero-based lines
> -----------------------------------------------
>
>                 Key: SPARK-10133
>                 URL: https://issues.apache.org/jira/browse/SPARK-10133
>             Project: Spark
>          Issue Type: Bug
>          Components: MLlib
>    Affects Versions: 1.4.1
>            Reporter: Xusen Yin
>            Priority: Minor
>
> https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala#L88
> The code wants to assure that each line of vector is one-based and in ascending order, but it fails since the previous = -1 in the beginning.
> In this condition, a libSVM format file that begins with 0-based index could read in normally, but the size of the according SparseVector is wrong, i.e. numFeatures - 1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org