You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2015/03/19 03:57:17 UTC
[GitHub] storm pull request: fastfix-01:modify config.read-supervisor-storm...
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/469
fastfix-01:modify config.read-supervisor-storm-conf function remove unused topology-path
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm fastfix-01
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #469
----
commit f95938b3d973a9d2513d0e326188f77b9bf438c8
Author: caofangkun <ca...@gmail.com>
Date: 2015-03-16T06:31:04Z
Merge pull request #12 from apache/master
Merge from apache/storm to caofangkun/apache-storm
commit 146bd6b7b18f03b338df78431654d7c54fa0e8a4
Author: caofangkun <ca...@gmail.com>
Date: 2015-03-18T01:17:37Z
Merge pull request #13 from apache/master
Merge from apache/storm to caofangkun/apache-storm
commit 57a691c865f764cf331abd2e2e6d27bd320813f8
Author: caofangkun <ca...@gmail.com>
Date: 2015-03-19T02:01:23Z
Merge pull request #14 from apache/master
Merge from apache/storm to caofangkun/apache-storm
commit 914d07758a2fbbfe237ca825374c038f29890194
Author: caofangkun <ca...@gmail.com>
Date: 2015-03-19T02:53:24Z
fastfix-01:modify config.read-supervisor-storm-conf function remove unused topology-path
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fastfix-01:Removed unused topology-path variab...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/469#issuecomment-167691552
@d2r this branch is outdated, I fired a new PR #981 and created jira [STORM-1424](https://issues.apache.org/jira/browse/STORM-1424) for it .
So close this first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fastfix-01:modify config.read-supervisor-storm...
Posted by lazyval <gi...@git.apache.org>.
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/469#issuecomment-88447333
Minor, but you would be better off with *"Removed unused `topology-path` variable"* as PR title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fastfix-01:Removed unused topology-path variab...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun closed the pull request at:
https://github.com/apache/storm/pull/469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fastfix-01:Removed unused topology-path variab...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/469#issuecomment-167629865
@caofangkun , is this pull request still valid? Would you create a Jira issue for it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---