You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@santuario.apache.org by "jrihtarsic (via GitHub)" <gi...@apache.org> on 2024/10/28 06:22:18 UTC

[PR] [SANTUARIO-622] XMLSignatureInput close input stream [santuario-xml-security-java]

jrihtarsic opened a new pull request, #406:
URL: https://github.com/apache/santuario-xml-security-java/pull/406

   This pull request includes Resource management enhancements of the inputOctetStreamProxy in the `XMLSignatureInput` class, to mitigate the issue described in  [SATUARIO-622].
   
   
   
   * [`src/main/java/org/apache/xml/security/signature/XMLSignatureInput.java`](diffhunk://#diff-6d3709a5ea6ec527779c8766e2a086461d2ae16bf549f024ff0fbfd9886f4e41L502-R512): Modified the `updateOutputStream` method to use a `BufferedInputStream` for more efficient reading and added a debug log statement for when the input stream is closed. (`[src/main/java/org/apache/xml/security/signature/XMLSignatureInput.javaL502-R512](diffhunk://#diff-6d3709a5ea6ec527779c8766e2a086461d2ae16bf549f024ff0fbfd9886f4e41L502-R512)`)
   * [`src/main/java/org/apache/xml/security/signature/XMLSignatureInput.java`](diffhunk://#diff-6d3709a5ea6ec527779c8766e2a086461d2ae16bf549f024ff0fbfd9886f4e41L502-R512): Ensured the input stream is properly closed and the `inputOctetStreamProxy` reference is removed after reading. (`[src/main/java/org/apache/xml/security/signature/XMLSignatureInput.javaL502-R512](diffhunk://#diff-6d3709a5ea6ec527779c8766e2a086461d2ae16bf549f024ff0fbfd9886f4e41L502-R512)`)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SANTUARIO-622] XMLSignatureInput close input stream [santuario-xml-security-java]

Posted by "jrihtarsic (via GitHub)" <gi...@apache.org>.
jrihtarsic commented on PR #406:
URL: https://github.com/apache/santuario-xml-security-java/pull/406#issuecomment-2452902128

   The debug statement is now removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SANTUARIO-622] XMLSignatureInput close input stream [santuario-xml-security-java]

Posted by "coheigea (via GitHub)" <gi...@apache.org>.
coheigea merged PR #406:
URL: https://github.com/apache/santuario-xml-security-java/pull/406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org