You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/01/15 01:58:35 UTC
[kudu-CR] build: disable more binaries/libraries when NO TESTS=1
Hello Henry Robinson, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5722
to review the following change.
Change subject: build: disable more binaries/libraries when NO_TESTS=1
......................................................................
build: disable more binaries/libraries when NO_TESTS=1
Fallout from commit b6acf36. These all depend on on kudu_test_main or
kudu_test_util (or both).
Change-Id: I187f2cce48d37be7be73de9c990ddb40306c6959
---
M src/kudu/benchmarks/CMakeLists.txt
M src/kudu/experiments/CMakeLists.txt
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/twitter-demo/CMakeLists.txt
4 files changed, 30 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/5722/1
--
To view, visit http://gerrit.cloudera.org:8080/5722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I187f2cce48d37be7be73de9c990ddb40306c6959
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] build: disable more binaries/libraries when NO TESTS=1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: build: disable more binaries/libraries when NO_TESTS=1
......................................................................
build: disable more binaries/libraries when NO_TESTS=1
Fallout from commit b6acf36. These all depend on on kudu_test_main or
kudu_test_util (or both).
Change-Id: I187f2cce48d37be7be73de9c990ddb40306c6959
Reviewed-on: http://gerrit.cloudera.org:8080/5722
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/benchmarks/CMakeLists.txt
M src/kudu/experiments/CMakeLists.txt
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/twitter-demo/CMakeLists.txt
4 files changed, 30 insertions(+), 15 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/5722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I187f2cce48d37be7be73de9c990ddb40306c6959
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] build: disable more binaries/libraries when NO TESTS=1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: build: disable more binaries/libraries when NO_TESTS=1
......................................................................
Patch Set 1: Code-Review+2 Verified+1
I'm pushing this early to unbreak some commit flow Jenkins jobs, but I'll address any post-commit comments in a new patch.
I tested this by building RELEASE with NO_TESTS=1, DEBUG normally, and DEBUG with NO_TESTS=1. All of the unit tests passed, and I also verified that the number of unit tests is the same before/after (i.e. I was afraid of accidentally disabling unit tests when NO_TESTS=0).
--
To view, visit http://gerrit.cloudera.org:8080/5722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I187f2cce48d37be7be73de9c990ddb40306c6959
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No