[GitHub] [spark] zhenlineo commented on a diff in pull request #40038: [WIP][CONNECT] Test `RootAllocator` memory leak

["zhenlineo (via GitHub)" <gi...@apache.org>]

zhenlineo commented on code in PR #40038:
URL: https://github.com/apache/spark/pull/40038#discussion_r1107933053


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -133,6 +133,7 @@ class SparkSession(private val client: SparkConnectClient, private val cleaner:
 
   override def close(): Unit = {
     client.shutdown()
+    cleaner.stop()

Review Comment:
   I am looking at this afternoon. We cannot directly shutdown the cleaner as it is shared by all sessions. I have some draft [here](https://github.com/zhenlineo/spark/pull/new/allocator-memleak). Be free to use any idea there. If you do not have more time on this. I will add some testing and send a PR tomorrow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org