You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Pei He (JIRA)" <ji...@apache.org> on 2017/04/01 02:42:41 UTC

[jira] [Commented] (BEAM-1854) Replace the magic number 42 in PAssert.

    [ https://issues.apache.org/jira/browse/BEAM-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951951#comment-15951951 ] 

Pei He commented on BEAM-1854:
------------------------------

For example, a string like "PAssert-global-key" would be better.

> Replace the magic number 42 in PAssert.
> ---------------------------------------
>
>                 Key: BEAM-1854
>                 URL: https://issues.apache.org/jira/browse/BEAM-1854
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>            Reporter: Pei He
>            Assignee: Davor Bonaci
>            Priority: Minor
>
> PAssert used integer 42 as the global key. It causes some confusion when debugging ValidatesRunner tests.
> final int combinedKey = 42;
> https://github.com/apache/beam/find/master#L935



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)