You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "aldettinger (via GitHub)" <gi...@apache.org> on 2023/03/15 14:00:37 UTC

[GitHub] [camel-quarkus] aldettinger opened a new issue, #4658: vertx-http: complete test coverage

aldettinger opened a new issue, #4658:
URL: https://github.com/apache/camel-quarkus/issues/4658

   The tests need to be improved:
    + Form parameters should be covered in Camel Quarkus tests
    + Multipart form data in Camel Quarkus tests
    + Customizing Vert.x client options in Camel Quarkus tests
    + SessionManagement in Camel Quarkus tests
    + Ensure that [serialization related](https://github.com/apache/camel/blob/d48f0bea2a21d3de97e058cda287c45651162335/components/camel-vertx/camel-vertx-http/src/main/java/org/apache/camel/component/vertx/http/VertxHttpProducer.java#L107) is covered by a native test or unsupported
    + getCharsetFromExchange() is used with VertxBufferConverter.@Converter.toBuffer(), check that there is no native issues as we `-H:-AddAllCharset` at build time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on issue #4658: vertx-http: complete test coverage

Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on issue #4658:
URL: https://github.com/apache/camel-quarkus/issues/4658#issuecomment-1487035068

   test coverage has been improved in pr:
    + Form parameters should be covered in Camel Quarkus tests **OK**
    + Multipart form data in Camel Quarkus tests **OK**
    + Customizing Vert.x client options in Camel Quarkus tests **OK**
    + SessionManagement in Camel Quarkus tests **OK**
    + Ensure that [serialization related](https://github.com/apache/camel/blob/d48f0bea2a21d3de97e058cda287c45651162335/components/camel-vertx/camel-vertx-http/src/main/java/org/apache/camel/component/vertx/http/VertxHttpProducer.java#L107) is covered by a native test or unsupported
     **OK** Already covered by transferException = true, doc added
    + getCharsetFromExchange() is used with VertxBufferConverter.@Converter.toBuffer(), check that there is no native issues as we `-H:-AddAllCharset` at build time
     **OK** doc added


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] aldettinger closed issue #4658: vertx-http: complete test coverage

Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger closed issue #4658: vertx-http: complete test coverage
URL: https://github.com/apache/camel-quarkus/issues/4658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on issue #4658: vertx-http: complete test coverage

Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on issue #4658:
URL: https://github.com/apache/camel-quarkus/issues/4658#issuecomment-1489072850

   It was merged in:
    + main https://github.com/apache/camel-quarkus/commit/34bf4efd7dbd3f2adb2265a20fb456849fc7ffef
    + 2.13.x https://github.com/apache/camel-quarkus/commit/9e0a7f83c802fa06b0e068d6a906697fdd57f3b3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org