You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/19 10:54:03 UTC
[GitHub] [skywalking] zhaoyuguang commented on a change in pull request #5347: Elastic job plugin use wrong span type
zhaoyuguang commented on a change in pull request #5347:
URL: https://github.com/apache/skywalking/pull/5347#discussion_r472940304
##########
File path: apm-sniffer/apm-sdk-plugin/elastic-job-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/elasticjob/ElasticJobExecutorInterceptor.java
##########
@@ -36,7 +35,7 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
ShardingContexts shardingContexts = (ShardingContexts) allArguments[0];
Integer item = (Integer) allArguments[1];
String operateName = ComponentsDefine.ELASTIC_JOB.getName() + "/" + shardingContexts.getJobName();
- AbstractSpan span = ContextManager.createEntrySpan(operateName, new ContextCarrier());
+ AbstractSpan span = ContextManager.createLocalSpan(operateName);
Review comment:
Elastic-job`s had specification logic-span
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org