You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/01 01:22:35 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7415:
Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8)
codecov-io commented on issue #7415: Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8)
URL: https://github.com/apache/incubator-superset/pull/7415#issuecomment-488170107
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7415?src=pr&el=h1) Report
> Merging [#7415](https://codecov.io/gh/apache/incubator-superset/pull/7415?src=pr&el=desc) into [lyft-release-sp8](https://codecov.io/gh/apache/incubator-superset/commit/bfd685e5a2c28818d6207f4b3ae4e37d1b559117?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `76.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7415?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## lyft-release-sp8 #7415 +/- ##
===================================================
- Coverage 65% 65% -0.01%
===================================================
Files 429 429
Lines 21081 21095 +14
Branches 2337 2337
===================================================
+ Hits 13704 13712 +8
- Misses 7253 7259 +6
Partials 124 124
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7415?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/7415/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <66.66%> (-11.8%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/7415/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `60.22% <86.66%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7415?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7415?src=pr&el=footer). Last update [bfd685e...138a4ca](https://codecov.io/gh/apache/incubator-superset/pull/7415?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org