You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/05 00:05:36 UTC
[GitHub] [incubator-tvm] zhiics opened a new pull request #4988:
[Refactor][Relay Build] refactor build module to take IRModule
zhiics opened a new pull request #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988
This PR refactors relay build_module interfaces to accept IRModules instead of Function. This can help external codegen that may need to lift functions into the global scope.
Many tests in the codebase have already passed IRModule to `relay.build`, so no additional unit test is added in this PR.
A follow up PR will be sent to add the outlining and inlining of subgraphs/sub-functions that are supported by external codegen.
cc @comaniac @icemelon9 @jroesch @tqchen @wweic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4988: [Refactor][Relay
Build] refactor build module to take IRModule
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988#issuecomment-595313695
Thanks @comaniac @tqchen @wweic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4988: [Refactor][Relay
Build] refactor build module to take IRModule
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988#issuecomment-595428966
@zhiics seems this change breaks the master ci, please look into it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4988: [Refactor][Relay
Build] refactor build module to take IRModule
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988#issuecomment-595008776
@wweic Its okay. Tutorials have already used module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics merged pull request #4988: [Refactor][Relay
Build] refactor build module to take IRModule
Posted by GitBox <gi...@apache.org>.
zhiics merged pull request #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] wweic commented on issue #4988: [Refactor][Relay
Build] refactor build module to take IRModule
Posted by GitBox <gi...@apache.org>.
wweic commented on issue #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988#issuecomment-595008421
LGTM. Should we also update the tutorials?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4988: [Refactor][Relay
Build] refactor build module to take IRModule
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988#issuecomment-594962642
Yeah, Python side still accepts `Function` as well. Its just a line of code `tvm::IRModule::FromExpr(func);` in c++, so I don't want to overload `Build`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4988: [Refactor][Relay
Build] refactor build module to take IRModule
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988#issuecomment-595457431
hmm, this actually revealed that the gcn tutorial didn't pass mod. We need to bind params when adding the function to the mod. Interestingly, it didn't fail for the last two runs before merging. #4994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4988: [Refactor][Relay
Build] refactor build module to take IRModule
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988#issuecomment-595436882
Okay. I will. Thanks for reminding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] comaniac commented on issue #4988: [Refactor][Relay
Build] refactor build module to take IRModule
Posted by GitBox <gi...@apache.org>.
comaniac commented on issue #4988: [Refactor][Relay Build] refactor build module to take IRModule
URL: https://github.com/apache/incubator-tvm/pull/4988#issuecomment-594964479
I see. That makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services