You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:35:49 UTC

[GitHub] [incubator-nuttx] cederom opened a new pull request #4672: tools/configure.sh: Detect and use GNU make (gmake) on BSD platforms.

cederom opened a new pull request #4672:
URL: https://github.com/apache/incubator-nuttx/pull/4672


   Linux uses GNU Make as default, command is `make`.
   BSD uses BSD Make as default, command is also `make`.
   BSD can also use GNU Make, but the command is `gmake`.
   This patch uses `make` on GNU platforms and `gmake` on BSD platforms.
   
   Signed-off-by: Tomasz 'CeDeROM' CEDRO <to...@cedro.info>
   
   ## Summary
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] cederom commented on pull request #4672: tools/configure.sh: Detect and use GNU make (gmake) on BSD platforms.

Posted by GitBox <gi...@apache.org>.

cederom commented on pull request #4672:
URL: https://github.com/apache/incubator-nuttx/pull/4672#issuecomment-944953332






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #4672: tools/configure.sh: Detect and use GNU make (gmake) on BSD platforms.

Posted by GitBox <gi...@apache.org>.

patacongo commented on pull request #4672:
URL: https://github.com/apache/incubator-nuttx/pull/4672#issuecomment-944954502


   There are two configuration programs tools/configure.sh and tools/configure.c.  The latter is faster if any cares about that but also works in any environment, not just bash.  configure.bat, for example, is just a wrapper around configure.c.
   
   Normally, we try to keep the functionality of these two versions the same.  I think it would need the same change in run_make().
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4672: tools/configure.sh: Detect and use GNU make (gmake) on BSD platforms.

Posted by GitBox <gi...@apache.org>.

Ouss4 commented on pull request #4672:
URL: https://github.com/apache/incubator-nuttx/pull/4672#issuecomment-944954274


   > Is tools/sethost.sh the central place for OS detection and environment setup?
   
   It's not, it sets some correct configurations in the `.config` file depending on the host.  At the end it calls `make olddefconfig`, this is why I mentioned that you probably need to change that too.  
   We don't have a file that contains all of these common variables/detections and we include it in all other script.  But I can see that one can come in handy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] cederom closed pull request #4672: tools/configure.sh: Detect and use GNU make (gmake) on BSD platforms.

Posted by GitBox <gi...@apache.org>.

cederom closed pull request #4672:
URL: https://github.com/apache/incubator-nuttx/pull/4672


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org