You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/12 23:05:37 UTC
[GitHub] [skywalking] cui-liqiang opened a new pull request #4355: some code
style and refactor
cui-liqiang opened a new pull request #4355: some code style and refactor
URL: https://github.com/apache/skywalking/pull/4355
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
None of above, just some refactoring and code style changes mainly in two patterns:
1. Change "if(xxx) return true; return false" to "return xxx;".
2. Change "while(rs.next()) return xxx" to "if() return xxx", since rs.next() invocation will not return true once it returns false. I only changed one occurrence, and I will change the rest if it's a correct change.
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4355: some code style
and refactor
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4355: some code style and refactor
URL: https://github.com/apache/skywalking/pull/4355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4355: some code
style and refactor
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #4355: some code style and refactor
URL: https://github.com/apache/skywalking/pull/4355#issuecomment-585519526
All plugin tests have passed except for one, PlayFramework, just because of network issue, and I'm sure it's not related to the changes here, I'll merge it now
> Could not transfer artifact com.typesafe.play:twirl-parser_2.12:pom:1.3.15 from/to central (https://repo.maven.apache.org/maven2): Failed to transfer file https://repo.maven.apache.org/maven2/com/typesafe/play/twirl-parser_2.12/1.3.15/twirl-parser_2.12-1.3.15.pom with status code 500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4355: some code style
and refactor
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4355: some code style and refactor
URL: https://github.com/apache/skywalking/pull/4355#issuecomment-585519526
All plugin tests have passed except for one, PlayFramework, just because of network issue, and I'm sure it's not related to the changes here, I'll merge it now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services