You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Qian Zhang (JIRA)" <ji...@apache.org> on 2017/09/28 09:32:02 UTC
[jira] [Updated] (MESOS-7975) The command/default/docker executor
can incorrectly send a TASK_FINISHED update even when the task is killed
[ https://issues.apache.org/jira/browse/MESOS-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Qian Zhang updated MESOS-7975:
------------------------------
Description:
Currently, when a task is killed, the default/command/docker executor incorrectly send a {{TASK_FINISHED}} status update instead of {{TASK_KILLED}}. This is due to an unfortunate missed conditional check when the task exits with a zero status code.
{code}
if (WSUCCEEDED(status)) {
taskState = TASK_FINISHED;
} else if (killed) {
// Send TASK_KILLED if the task was killed as a result of
// kill() or shutdown().
taskState = TASK_KILLED;
} else {
taskState = TASK_FAILED;
}
{code}
We should modify the code to correctly send {{TASK_KILLED}} status updates when a task is killed.
was:
Currently, when a task is killed, the default and the command executor incorrectly send a {{TASK_FINISHED}} status update instead of {{TASK_KILLED}}. This is due to an unfortunate missed conditional check when the task exits with a zero status code.
{code}
if (WSUCCEEDED(status)) {
taskState = TASK_FINISHED;
} else if (killed) {
// Send TASK_KILLED if the task was killed as a result of
// kill() or shutdown().
taskState = TASK_KILLED;
} else {
taskState = TASK_FAILED;
}
{code}
We should modify the code to correctly send {{TASK_KILLED}} status updates when a task is killed.
Summary: The command/default/docker executor can incorrectly send a TASK_FINISHED update even when the task is killed (was: The command/default executor can incorrectly send a TASK_FINISHED update even when the task is killed)
> The command/default/docker executor can incorrectly send a TASK_FINISHED update even when the task is killed
> ------------------------------------------------------------------------------------------------------------
>
> Key: MESOS-7975
> URL: https://issues.apache.org/jira/browse/MESOS-7975
> Project: Mesos
> Issue Type: Bug
> Reporter: Anand Mazumdar
> Assignee: Qian Zhang
> Priority: Critical
> Labels: mesosphere
>
> Currently, when a task is killed, the default/command/docker executor incorrectly send a {{TASK_FINISHED}} status update instead of {{TASK_KILLED}}. This is due to an unfortunate missed conditional check when the task exits with a zero status code.
> {code}
> if (WSUCCEEDED(status)) {
> taskState = TASK_FINISHED;
> } else if (killed) {
> // Send TASK_KILLED if the task was killed as a result of
> // kill() or shutdown().
> taskState = TASK_KILLED;
> } else {
> taskState = TASK_FAILED;
> }
> {code}
> We should modify the code to correctly send {{TASK_KILLED}} status updates when a task is killed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)