You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/30 09:48:40 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
mattisonchao opened a new pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
### Motivation
As the code is shown below, If the ``doAcknowledge``throws exception, the ``result`` future can't complete.
```java
typedMessageBuilderNew.sendAsync()
.thenAccept(__ -> doAcknowledge(finalMessageId, ackType, Collections.emptyMap(), null)
.thenAccept(v -> result.complete(null)))
.exceptionally(ex -> {
result.completeExceptionally(ex);
return null;
});
```
### Modifications
- Use ``thenCompose`` to instead of ``thenAccept``.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao edited a comment on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao edited a comment on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1086027367
> @mattisonchao Please rebase this PR. It seems that without rebasing `/pulsarbot rerun-failure-checks` will run some old jobs.
Thank you. @lhotari
It looks like reopening this PR doesn't work. So, I rebase the code myself and then the CI works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1085860220
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1086450031
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao edited a comment on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao edited a comment on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1086027367
> @mattisonchao Please rebase this PR. It seems that without rebasing `/pulsarbot rerun-failure-checks` will run some old jobs.
Thank you. @lhotari
It looks like reopening this PR doesn't work. So, I rebase the code myself and CI worked fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1085965052
@mattisonchao Please rebase this PR. It seems that without rebasing `/pulsarbot rerun-failure-checks` will run some old jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1086040786
> > @mattisonchao Please rebase this PR. It seems that without rebasing `/pulsarbot rerun-failure-checks` will run some old jobs.
>
> Thank you. @lhotari It looks like reopening this PR doesn't work. So, I rebase the code myself and then the CI works fine.
Exactly. My advice to close and reopen was wrong. Please check https://lists.apache.org/thread/vl00z7o3cmjcx2f49tfb4wxtj7mdhbz2 for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao edited a comment on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao edited a comment on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1086027367
> @mattisonchao Please rebase this PR. It seems that without rebasing `/pulsarbot rerun-failure-checks` will run some old jobs.
Thank you. @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1086027367
> @mattisonchao Please rebase this PR. It seems that without rebasing `/pulsarbot rerun-failure-checks` will run some old jobs.
Thanks for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao edited a comment on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao edited a comment on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1086027367
> @mattisonchao Please rebase this PR. It seems that without rebasing `/pulsarbot rerun-failure-checks` will run some old jobs.
Thank you. @lhotari
It looks like reopening this PR doesn't work. So, I re-coded the code myself and CI worked fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1083592364
Closing and reopening to get latest CI changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14947:
URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1086542369
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org