Re: [PR] [SPARK-46265][CONNECT] Assertions in AddArtifact RPC make the connect client incompatible with older clusters [spark]

["grundprinzip (via GitHub)" <gi...@apache.org>]

grundprinzip commented on code in PR #44181:
URL: https://github.com/apache/spark/pull/44181#discussion_r1415358128


##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/ArtifactManager.scala:
##########
@@ -125,7 +125,7 @@ class ArtifactManager(
       .addAllNames(Arrays.asList(artifactName))
       .build()
     val response = bstub.artifactStatus(request)
-    if (response.getSessionId != sessionId) {
+    if (StringUtils.isNotEmpty(response.getSessionId) && response.getSessionId != sessionId) {

Review Comment:
   Maybe add a comment that explains why an empty session ID is treated differently. Here and below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org