You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/08/13 19:55:50 UTC

[GitHub] jihoonson commented on a change in pull request #6168: Fix NPE for taskGroupId when rolling update

jihoonson commented on a change in pull request #6168: Fix NPE for taskGroupId when rolling update
URL: https://github.com/apache/incubator-druid/pull/6168#discussion_r209737869
 
 

 ##########
 File path: indexing-service/src/main/java/io/druid/indexing/overlord/supervisor/SupervisorManager.java
 ##########
 @@ -165,7 +165,8 @@ public boolean resetSupervisor(String id, @Nullable DataSourceMetadata dataSourc
 
   public boolean checkPointDataSourceMetadata(
       String supervisorId,
-      int taskGroupId,
+      @Nullable String taskId,
+      Integer taskGroupId,
 
 Review comment:
   Thanks. Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org