You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/12 04:23:17 UTC
[GitHub] [superset] stephenLYZ opened a new pull request, #21432: fix(dashboard): drag preview not working
stephenLYZ opened a new pull request, #21432:
URL: https://github.com/apache/superset/pull/21432
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Currently the drag preview of `react-dnd` was broken since we introduce `position: 'fixed'` inside the drag container from [#21198](https://github.com/apache/superset/pull/21198/files#diff-ea949f68550922078a8f7fb0b3d73d166697eaa03d01d6b0178cfa66feb1ac06L114). To fix this, we use `createPortal` to ensure that the parent container is not affected and that the dropdown is also displayed properly.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
#### before
https://user-images.githubusercontent.com/11830681/189573591-61756ae5-ab2d-4944-add2-fd7408c29ee0.mov
#### after
https://user-images.githubusercontent.com/11830681/189573411-91bb0976-37b7-4a38-9b4a-340ba19efccf.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #21432: fix(dashboard): drag preview not working
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #21432:
URL: https://github.com/apache/superset/pull/21432#issuecomment-1243546328
@stephenLYZ I'm still able to reproduce the issue. If I remove `ChartContextMenu` completely, the error still happens so I do think it's related to that component.
https://user-images.githubusercontent.com/70410625/189633209-68d78f9b-896f-4cd5-81d1-5486bb31060b.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21432: fix(dashboard): drag preview not working
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21432:
URL: https://github.com/apache/superset/pull/21432#issuecomment-1243228351
# [Codecov](https://codecov.io/gh/apache/superset/pull/21432?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21432](https://codecov.io/gh/apache/superset/pull/21432?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb8eed6) into [master](https://codecov.io/gh/apache/superset/commit/7401f15addda7e42ce9bf8adb966834ec0687278?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7401f15) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #21432 +/- ##
=======================================
Coverage 66.56% 66.56%
=======================================
Files 1791 1791
Lines 68591 68591
Branches 7319 7319
=======================================
Hits 45656 45656
Misses 21046 21046
Partials 1889 1889
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.74% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Chart/ChartContextMenu.tsx](https://codecov.io/gh/apache/superset/pull/21432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvQ2hhcnRDb250ZXh0TWVudS50c3g=) | `44.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ merged pull request #21432: fix(dashboard): drag preview not working
Posted by GitBox <gi...@apache.org>.
stephenLYZ merged PR #21432:
URL: https://github.com/apache/superset/pull/21432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #21432: fix(dashboard): drag preview not working
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #21432:
URL: https://github.com/apache/superset/pull/21432#issuecomment-1243607443
> @michael-s-molina This is actually another problem with the pivot table v2, because it also uses fixed position , and we may need to use another PR to solve it. But for the rest of the chart, everything looks fine. During my troubleshooting, I found that this commit was fine before, but afterwards the behavior was not as expected, so I'm guessing that this is what's affecting it.
Oh, thanks for clarifying that. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch commented on pull request #21432: fix(dashboard): drag preview not working
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on PR #21432:
URL: https://github.com/apache/superset/pull/21432#issuecomment-1244757125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #21432: fix(dashboard): drag preview not working
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #21432:
URL: https://github.com/apache/superset/pull/21432#issuecomment-1243567529
> @stephenLYZ I'm still able to reproduce the issue. If I remove `ChartContextMenu` completely, the error still happens so I don't think it's related to that component.
>
> Screen.Recording.2022-09-12.at.7.33.44.AM.mov
@michael-s-molina This is actually another problem with the pivot table v2, because it also uses fixed position , and we may need to use another PR to solve it. But for the rest of the chart, everything looks fine if we don't use fixed position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org