You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/05 08:56:42 UTC
[GitHub] [incubator-doris] acelyc111 opened a new pull request #4021: [webserver] Make BE webserver handle static files
acelyc111 opened a new pull request #4021:
URL: https://github.com/apache/incubator-doris/pull/4021
Make BE webserver handle static files, e.g. css, js, ico, then we can make
BE website more pretty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on pull request #4021: [webserver] Make BE webserver handle static files
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #4021:
URL: https://github.com/apache/incubator-doris/pull/4021#issuecomment-655569283
A step for https://github.com/apache/incubator-doris/issues/3911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4021: [webserver] Make BE webserver handle static files
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4021:
URL: https://github.com/apache/incubator-doris/pull/4021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #4021: [webserver] Make BE webserver handle static files
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #4021:
URL: https://github.com/apache/incubator-doris/pull/4021#discussion_r449888388
##########
File path: be/src/common/config.h
##########
@@ -536,6 +536,8 @@ namespace config {
// Whether to continue to start be when load tablet from header failed.
CONF_Bool(ignore_load_tablet_failure, "false");
+ // Directory where BE's website files placed.
+ CONF_String(www_path, "${DORIS_HOME}/www");
Review comment:
Seems not necessary, I'll remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4021: [webserver] Make BE webserver handle static files
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4021:
URL: https://github.com/apache/incubator-doris/pull/4021#discussion_r449882043
##########
File path: be/src/common/config.h
##########
@@ -536,6 +536,8 @@ namespace config {
// Whether to continue to start be when load tablet from header failed.
CONF_Bool(ignore_load_tablet_failure, "false");
+ // Directory where BE's website files placed.
+ CONF_String(www_path, "${DORIS_HOME}/www");
Review comment:
Is it necessary to be a config? I think it can be hard coded?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org