[jira] [Commented] (KYLIN-3648) Kylin may not add "kylin.storage.hbase.cluster-hdfs-config-file" to configuration properly

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720889#comment-16720889 ] 

ASF subversion and git services commented on KYLIN-3648:
--------------------------------------------------------

Commit 1358e801990b1059ddbc4133381a74a77d66105b in kylin's branch refs/heads/master from shaofengshi
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=1358e80 ]

Revert "KYLIN-3648 Use Path as the input of addResource"

This reverts commit 3bcef1a186b1cb3794f23bb26db8362e68c76335.


> Kylin may not add "kylin.storage.hbase.cluster-hdfs-config-file" to configuration properly
> ------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-3648
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3648
>             Project: Kylin
>          Issue Type: Bug
>          Components: Storage - HBase
>            Reporter: Shaofeng SHI
>            Assignee: Chao Long
>            Priority: Minor
>             Fix For: v2.6.0
>
>
> From this blog,  we know that Configuration.addResource should better use a Path as the input instead of a string:
> conf.addResource(new Path("/home/hadoop/conf/core-site.xml"));
> [https://dzone.com/articles/debugging-%E2%80%9Cwrong-fs-expected]
>  
> But in Kylin's HBaseConnection, it add the hbase cluster fs configure file as string:
> {code:java}
> String hdfsConfigFile = KylinConfig.getInstanceFromEnv().getHBaseClusterHDFSConfigFile();
> if (hdfsConfigFile == null || hdfsConfigFile.isEmpty()) {
>     return;
> }
> Configuration hdfsConf = new Configuration(false);
> hdfsConf.addResource(hdfsConfigFile);
> {code}
> This may make it doesn't work.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)