[GitHub] [tvm] mbs-octoml commented on pull request #8795: [2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op

[GitBox <gi...@apache.org>]

mbs-octoml commented on pull request #8795:
URL: https://github.com/apache/tvm/pull/8795#issuecomment-910477523


   re dir structure:  agree given the tight coupling better to keep them together, no need to move around.
   
   I see @Mousius is pushing on the hooks RFC again - I'll try to help get that in place in time for PR4 so we can avoid the bespoke lower te.
   
   Some OctoML folks went through the code (as at PR6) with me yesterday so I understand the te+schedule stuff better now. I would suggest more big-picture comments in both the te and scheduling code since things were not obvious even to experts on our side.
   
   For this PR I think it's just the type annots remaining? That will require a change to mypi.ini to turn it on, but if that unleashes a storm of secondary issues lets reconsider.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org