You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "He Yongqiang (JIRA)" <ji...@apache.org> on 2009/05/21 11:30:45 UTC
[jira] Created: (HIVE-502) Optimize RCFile's performance by
removeing all synchronized modifiers
Optimize RCFile's performance by removeing all synchronized modifiers
---------------------------------------------------------------------
Key: HIVE-502
URL: https://issues.apache.org/jira/browse/HIVE-502
Project: Hadoop Hive
Issue Type: Improvement
Components: Query Processor
Reporter: He Yongqiang
Tests by Zheng and me both show that removing all synchronized modifiers can improve RCFile's performance by about 15+%.
This will make RCFile's reader and writer not thread safe any longer. This will be ok,since hive always does its work in single thread.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-502) Optimize RCFile's performance by
removeing all synchronized modifiers
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-502:
------------------------------
Attachment: hive-502-2009-05-21.patch
> Optimize RCFile's performance by removeing all synchronized modifiers
> ---------------------------------------------------------------------
>
> Key: HIVE-502
> URL: https://issues.apache.org/jira/browse/HIVE-502
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: He Yongqiang
> Attachments: hive-502-2009-05-21.patch
>
>
> Tests by Zheng and me both show that removing all synchronized modifiers can improve RCFile's performance by about 15+%.
> This will make RCFile's reader and writer not thread safe any longer. This will be ok,since hive always does its work in single thread.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-502) Optimize RCFile's performance by
removeing all synchronized modifiers
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711948#action_12711948 ]
Zheng Shao commented on HIVE-502:
---------------------------------
In the future if needed, we can add synchronized keyword to RCFile's read/write methods.
These methods will be called once per row, so the cost is much smaller than what we had - once per row per column.
> Optimize RCFile's performance by removeing all synchronized modifiers
> ---------------------------------------------------------------------
>
> Key: HIVE-502
> URL: https://issues.apache.org/jira/browse/HIVE-502
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: He Yongqiang
> Attachments: hive-502-2009-05-21.patch
>
>
> Tests by Zheng and me both show that removing all synchronized modifiers can improve RCFile's performance by about 15+%.
> This will make RCFile's reader and writer not thread safe any longer. This will be ok,since hive always does its work in single thread.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-502) Optimize RCFile's performance by
removeing all synchronized modifiers
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao reassigned HIVE-502:
-------------------------------
Assignee: He Yongqiang
> Optimize RCFile's performance by removeing all synchronized modifiers
> ---------------------------------------------------------------------
>
> Key: HIVE-502
> URL: https://issues.apache.org/jira/browse/HIVE-502
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: hive-502-2009-05-21.patch
>
>
> Tests by Zheng and me both show that removing all synchronized modifiers can improve RCFile's performance by about 15+%.
> This will make RCFile's reader and writer not thread safe any longer. This will be ok,since hive always does its work in single thread.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-502) Optimize RCFile's performance by
removeing all synchronized modifiers
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-502:
------------------------------
Attachment: hive-502-2009-05-22.patch
Fix a typo in class HiveDataInputBuffer's comment. Thanks, Zheng.
> Optimize RCFile's performance by removeing all synchronized modifiers
> ---------------------------------------------------------------------
>
> Key: HIVE-502
> URL: https://issues.apache.org/jira/browse/HIVE-502
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: hive-502-2009-05-21.patch, hive-502-2009-05-22.patch
>
>
> Tests by Zheng and me both show that removing all synchronized modifiers can improve RCFile's performance by about 15+%.
> This will make RCFile's reader and writer not thread safe any longer. This will be ok,since hive always does its work in single thread.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HIVE-502) Optimize RCFile's performance by
removeing all synchronized modifiers
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao resolved HIVE-502.
-----------------------------
Resolution: Fixed
Fix Version/s: 0.4.0
Release Note: HIVE-502. Optimize RCFile's performance by removeing all synchronized modifiers. (Yongqiang He via zshao)
Hadoop Flags: [Reviewed]
Committed. Thanks Yongqiang.
Note that this transaction only changes 5 files - none of which is used by Hive by default.
M CHANGES.txt
A ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveInputOutputBuffer.java
A ql/src/java/org/apache/hadoop/hive/ql/io/HiveDataInputBuffer.java
A ql/src/java/org/apache/hadoop/hive/ql/io/HiveDataOutputBuffer.java
M ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
> Optimize RCFile's performance by removeing all synchronized modifiers
> ---------------------------------------------------------------------
>
> Key: HIVE-502
> URL: https://issues.apache.org/jira/browse/HIVE-502
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Fix For: 0.4.0
>
> Attachments: hive-502-2009-05-21.patch, hive-502-2009-05-22.patch
>
>
> Tests by Zheng and me both show that removing all synchronized modifiers can improve RCFile's performance by about 15+%.
> This will make RCFile's reader and writer not thread safe any longer. This will be ok,since hive always does its work in single thread.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.