You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "markt-asf (via GitHub)" <gi...@apache.org> on 2023/05/30 11:24:29 UTC
[GitHub] [tomcat] markt-asf opened a new pull request, #623: BZ 66513: Enforce one concurrent request per session requirement
markt-asf opened a new pull request, #623:
URL: https://github.com/apache/tomcat/pull/623
This is untested.
If accepted, this will need some documentation updates.
The purpose of this draft is to obtain early feedback on the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmannibucau commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568571457
* Is there a plan for the map eviction? background thread?
* How does it work in a cluster since counter is local, should it be a cluster event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] jfclere commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
Posted by "jfclere (via GitHub)" <gi...@apache.org>.
jfclere commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570527918
@markt-asf that looks better that what was there ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570461148
I haven't deprecated this yet. I'm waiting on input from the OP of BZ 66513 and/or @jfclere as the original author of the Valve in case there is a use case I have missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568591682
Map eviction is handled in the finally block.
That we can only make this work on a single node is why Rémy is proposing that we remove/deprecate this Valve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570534844
> @markt-asf that looks better that what was there ;-)
Thanks.
Can you recall if there was a use case for this Valve on a single node? Or was it always intended for use behind a non-sticky load-balancer and, therefore, it was up to the client to enforce the "no more than one concurrent request per session" rule?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570477734
Very clean overall, esp the javadoc update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] jfclere commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
Posted by "jfclere (via GitHub)" <gi...@apache.org>.
jfclere commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570546656
trying to remember... I guess I wrote to save and restore session information for a SINGLE tomcat node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf merged pull request #623: BZ 66513: Enforce one concurrent request per session requirement
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf merged PR #623:
URL: https://github.com/apache/tomcat/pull/623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568565624
That seems like the better way to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org