You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/07 09:24:58 UTC
[GitHub] elloooooo commented on a change in pull request #6768: extension
for exactly distinct count for single long type
dimension:accurate-cardinality
elloooooo commented on a change in pull request #6768: extension for exactly distinct count for single long type dimension:accurate-cardinality
URL: https://github.com/apache/incubator-druid/pull/6768#discussion_r254600034
##########
File path: .idea/inspectionProfiles/Druid.xml
##########
@@ -31,7 +31,7 @@
<inspection_tool class="CovariantEquals" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="DuplicateBooleanBranch" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="DuplicateCondition" enabled="true" level="ERROR" enabled_by_default="true">
- <option name="ignoreSideEffectConditions" value="true" />
+ <option name="ignoreMethodCalls" value="false" />
Review comment:
> These changes seem unrelated to this PR?
Yes, I'll remove the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org