You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Dean Gaudet <dg...@arctic.org> on 1999/02/19 23:46:30 UTC
Re: cvs commit: apache-1.3/src/modules/standard mod_log_config.c
On 17 Feb 1999 coar@hyperreal.org wrote:
> Add conditional logging based upon environment variable existence.
> Also add RefererIgnore functionality from mod_log_referer to
> mod_log_config; mod_log_referer and mod_log_agent are now
> deprecated. The list of envariables to check is set up as
> an array even though the current implementation (TAKE23)
> only handles one; just in case we ever want to do something
> strange like, 'env=foo,bar,!bag'.
I don't recall there being a general consensus on deprecating
mod_log_agent and mod_log_referer.
I seem to recall there being at least two of us that didn't see the point
of putting RefererIgnore into mod_log_config, because the env control
solves it just fine.
I don't see the point of an array that only ever has one element -- if we
need multiple environment variables in the future we can get the code from
archives. I don't see the point of the "int conditions" when it's the
same as saying "condition_list != NULL".
I thought all these concerns were voiced when you posted the earlier patch
for comments.
-1.
Dean
Re: cvs commit: apache-1.3/src/modules/standard mod_log_config.c
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Dean Gaudet wrote:
>
> I don't recall there being a general consensus on deprecating
> mod_log_agent and mod_log_referer.
I see something resembling a general sense for this in the
nh.9708 archive.
> I seem to recall there being at least two of us that didn't see the point
> of putting RefererIgnore into mod_log_config, because the env control
> solves it just fine.
And there were several who wanted it maintained for compatibility.
I'm +0 on taking RefererIgnore back out.
> I don't see the point of an array that only ever has one element -- if we
> need multiple environment variables in the future we can get the code from
> archives.
All right.
> I don't see the point of the "int conditions" when it's the
> same as saying "condition_list != NULL".
Good point. Your original suggestion was to check for
nelts == 0, which meant a pointer fetch and dereference.
> I thought all these concerns were voiced when you posted the earlier patch
> for comments.
I don't think so. The RefererIgnore one, yes. The int versus an
array, yes. You said you didn't see a reason for them, and I explained
why I *did* see a reason. Since you didn't complain I figured
you were satisfied. You also asked for general envariable handling,
so that went in, so the RefererIgnore stuff can come back out;
no one else seems to feel strongly about it.
--
#ken P-)}
Ken Coar <http://Web.Golux.Com/coar/>
Apache Group member <http://www.apache.org/>
"Apache Server for Dummies" <http://Web.Golux.Com/coar/ASFD/>
Re: cvs commit: apache-1.3/src/modules/standard mod_log_config.c
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Dean Gaudet wrote:
>
> On Fri, 19 Feb 1999, Rodent of Unusual Size wrote:
>
> > Concerns addressed?
>
> Thanks.
Yer keeping me honest.. ;->
--
#ken P-)}
Ken Coar <http://Web.Golux.Com/coar/>
Apache Group member <http://www.apache.org/>
"Apache Server for Dummies" <http://Web.Golux.Com/coar/ASFD/>
Re: cvs commit: apache-1.3/src/modules/standard mod_log_config.c
Posted by Dean Gaudet <dg...@arctic.org>.
On Fri, 19 Feb 1999, Rodent of Unusual Size wrote:
> Concerns addressed?
Thanks.
Dean
Re: cvs commit: apache-1.3/src/modules/standard mod_log_config.c
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Dean Gaudet wrote:
>
> I don't recall there being a general consensus on deprecating
> mod_log_agent and mod_log_referer.
*shrug* a docco issue.
> I seem to recall there being at least two of us that didn't see the point
> of putting RefererIgnore into mod_log_config, because the env control
> solves it just fine.
It's gone.
> I don't see the point of an array that only ever has one element -- if we
> need multiple environment variables in the future we can get the code from
> archives. I don't see the point of the "int conditions" when it's the
> same as saying "condition_list != NULL".
Fixed.
> -1.
Concerns addressed?
--
#ken P-)}
Ken Coar <http://Web.Golux.Com/coar/>
Apache Group member <http://www.apache.org/>
"Apache Server for Dummies" <http://Web.Golux.Com/coar/ASFD/>