You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "innerpeacez (via GitHub)" <gi...@apache.org> on 2023/04/27 07:01:12 UTC
[GitHub] [skywalking-booster-ui] innerpeacez opened a new pull request, #262: feat: mq,cache menu
innerpeacez opened a new pull request, #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #262: feat: mq,cache menu
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1524997463
Redis is a database rather than a cache from Redis official perspective.
Do you have others to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #262: feat: add mq menu
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525257626
Work for me.
Is this PR ready to merge? @innerpeacez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] innerpeacez commented on pull request #262: feat: add mq menu
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525272702
> WDYT @wu-sheng @innerpeacez
>
> <img alt="1" width="1294" src="https://user-images.githubusercontent.com/20871783/234819754-a13df7cb-3025-43c0-a72c-7cb3f3a220ba.png">
Nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] innerpeacez commented on pull request #262: feat: add mq menu
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525277347
> Is this PR ready to merge? @innerpeacez
I think it's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] innerpeacez commented on pull request #262: feat: mq,cache menu
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1524926367
The icon was given to me by ChatGPT. If it's not good enough, it can be modified again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #262: feat: mq,cache menu
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525022260
> > The queue icon seems strange. We need a new one, and also we should have the ownership(new rather than a copy) for License perspective.
>
>
>
> For the icon, I don't have any specific idea. Can you provide an SVG file for me?
@Fine0830 Could you build one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] innerpeacez commented on pull request #262: feat: mq,cache menu
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525014372
> Redis is a database rather than a cache from Redis official perspective.
Do you have others to add?
Not at the moment, I just made some quick changes. I will roll it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #262: feat: add mq menu
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525249932
WDYT @wu-sheng @innerpeacez
<img width="1294" alt="1" src="https://user-images.githubusercontent.com/20871783/234819754-a13df7cb-3025-43c0-a72c-7cb3f3a220ba.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] innerpeacez commented on pull request #262: feat: mq,cache menu
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525017942
> The queue icon seems strange. We need a new one, and also we should have the ownership(new rather than a copy) for License perspective.
For the icon, I don't have any specific idea. Can you provide an SVG file for me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #262: feat: add mq menu
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #262: feat: mq,cache menu
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525029851
> > > The queue icon seems strange. We need a new one, and also we should have the ownership(new rather than a copy) for License perspective.
> >
> >
> > For the icon, I don't have any specific idea. Can you provide an SVG file for me?
>
> @Fine0830 Could you build one?
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #262: feat: mq,cache menu
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525001886
> The icon was given to me by ChatGPT. If it's not good enough, it can be modified again.
>
>
The queue icon seems strange. We need a new one, and also we should have the ownership(new rather than a copy) for License perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] innerpeacez commented on pull request #262: feat: add mq menu
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #262:
URL: https://github.com/apache/skywalking-booster-ui/pull/262#issuecomment-1525055326
> > > > The queue icon seems strange. We need a new one, and also we should have the ownership(new rather than a copy) for License perspective.
> > >
> > >
> > > For the icon, I don't have any specific idea. Can you provide an SVG file for me?
> >
> >
> > @Fine0830 Could you build one?
>
> Sure.
thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org