You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2018/07/02 09:42:29 UTC
Re: Review Request 67791: Prevented master from asking agents to
shutdown on auth failures.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/#review205631
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On July 2, 2018, 7:04 a.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67791/
> -----------------------------------------------------------
>
> (Updated July 2, 2018, 7:04 a.m.)
>
>
> Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.
>
>
> Bugs: MESOS-8987
> https://issues.apache.org/jira/browse/MESOS-8987
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Mesos master sends a `ShutdownMessage` to an agent if there is an
> authentication or an authorization error during agent (re)registration.
>
> Upon receipt of this message, the agent kills alls its tasks and commits
> suicide. This means that transient auth errors can lead to whole agents
> being killed along with it's tasks.
>
> This patch prevents the master from sending a `ShutdownMessage` in these
> cases.
>
>
> Diffs
> -----
>
> src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
> src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017
> src/tests/master_authorization_tests.cpp 80b9d49ba334b915461ff5d6df6c9f922d7593e3
>
>
> Diff: https://reviews.apache.org/r/67791/diff/1/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh` on GNU/Linux
>
>
> Thanks,
>
> Gastón Kleiman
>
>