You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/04/01 13:11:32 UTC

[GitHub] [ignite] ivandasch commented on a change in pull request #9927: IGNITE-16711 SQL Calcite: Fix numeric dynamic parameters conversion

ivandasch commented on a change in pull request #9927:
URL: https://github.com/apache/ignite/pull/9927#discussion_r840570874



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/ddl/ColumnDefinition.java
##########
@@ -71,13 +72,13 @@ public boolean nullable() {
      * @return Column's precision.
      */
     public Integer precision() {
-        return type.getPrecision() != RelDataType.PRECISION_NOT_SPECIFIED ? type.getPrecision() : null;
+        return TypeUtils.hasPrecesion(type) ? type.getPrecision() : null;

Review comment:
       Ok, make sense




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org