[jira] Issue Comment Edited: (THRIFT-252) Python libraries unable to build with MSVC on Windows

["Michael Greene (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661419#action_12661419 ] 

euphoria edited comment on THRIFT-252 at 1/6/09 7:03 PM:
---------------------------------------------------------------

Here is the patch.  I'm open to suggestions on how to handle the MSVC definitions in fastbinary.c
Bundled versions of stdint.h and stdbool.h could be distributed and included only on MSVC, but that seemed like overkill.  A platform.h for the python libs make sense if this clutters it too much, but it's really only a dozen lines or so.

This patch was tested on Ubuntu 8.10 / gcc 4.3.2 / python 2.5.2, Cygwin on XP / gcc 3.4.4 / python 2.5.2, and Vista / MSVC 9 (Visual C++ 2008 Express Edition) / python 2.6

      was (Author: euphoria):
    Here is the patch.  I'm open to suggestions on how to handle the MSVC definitions in fastbinary.c
Bundled versions of stdint.h and stdbool.h could be distributed and included only on MSVC, but that seemed like overkill.  A platform.h for the python libs make sense if this clutters it too much, but it's really only a dozen lines or so.
  
> Python libraries unable to build with MSVC on Windows
> -----------------------------------------------------
>
>                 Key: THRIFT-252
>                 URL: https://issues.apache.org/jira/browse/THRIFT-252
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Python)
>         Environment: Windows XP or Vista, Visual C++ 2008 (and likely others)
>            Reporter: Michael Greene
>            Assignee: Michael Greene
>         Attachments: thrift-252-python-msvc-1.diff
>
>
> This patch adds support for Visual C++ on Windows to the Python libraries.  stdbool and stdint are not available on MSVC, so alternates were defined.  netinet is replaced with winsock2.
> Additionally, setup.py is updated to support this platform and with the latest project information.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.