You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/07 11:36:43 UTC
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #668: [FEATURE] Disable values starting with a space
andrijapanicsb opened a new issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668
Copying the global setting value (or some other value from UI), adds space in front of the copied text, then when pasting I managed to have a template whose name starts with space....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688691387
@andrijapanicsb it may cause unexpected results in some cases, what is somebody wants to put space in front/end of a string input? Does old UI trim the space too ? I'm tentatively pushing this to 1.1 as it's not a critical/blocker issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-689314468
Fixed in the backend via https://github.com/apache/cloudstack/pull/4311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-689871929
Closing based on @davidjumani 's remark, the fix at backend needs to be cautious but will ultimately fix the issue for all kinds of client inputs (UI, API...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688768160
David checked and it's an issue at backend, fixing this in UI will still allow API to do this - so ideally the backend should trim the space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688768160
David checked and it's an issue at backend, fixing this in UI will still allow API to do this - so ideally the backend should trim the space. Note - in backend, all API requests are handled by a parameter utility that parses values to strings/ints/long/short etc there a fix can be implemented to trim for String input/API parameters cc @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688273991
@rhtyd @davidjumani can we have textinput to trim entered text while submitting the form?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-689871929
Closing based on @davidjumani 's remark, the fix at backend needs to be cautious but will utlimately fix the issue for all kinds of client inputs (UI, API...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688624774
We can do it both ways, but it would be better to trim it during the submit, to reduce the code changes introduced
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #668: [FEATURE] Disable values starting with a space
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #668:
URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688590543
@rhtyd I think we need to trim text input after entered?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org