You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-dev@hadoop.apache.org by Tom Graves <tg...@yahoo.com> on 2011/06/07 16:51:37 UTC

Re: Review Request: HADOOP-7314 Add support for throwing UnknownHostException when a host doesn't resolve

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/775/#review775
-----------------------------------------------------------

Ship it!


+1 Looks good.

- Tom


On 2011-05-23 15:49:39, Jeffrey Naisbitt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/775/
> -----------------------------------------------------------
> 
> (Updated 2011-05-23 15:49:39)
> 
> 
> Review request for hadoop-common and hadoop-mapreduce.
> 
> 
> Summary
> -------
> 
> As part of MAPREDUCE-2489, we need support for having the resolve methods (for DNS mapping) throw UnknownHostExceptions. (Currently, they hide the exception). Since the existing 'resolve' method is ultimately used by several other locations/components, I propose we add a new 'resolveValidHosts' method.
> 
> 
> This addresses bug HADOOP-7314.
>     https://issues.apache.org/jira/browse/HADOOP-7314
> 
> 
> Diffs
> -----
> 
>   trunk/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java 1125067 
>   trunk/src/java/org/apache/hadoop/net/ScriptBasedMapping.java 1125067 
>   trunk/src/test/core/org/apache/hadoop/net/StaticMapping.java 1125067 
>   trunk/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java 1125067 
>   trunk/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java 1125067 
> 
> Diff: https://reviews.apache.org/r/775/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeffrey
> 
>