You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/06/02 19:59:33 UTC
Review Request 22148: Fixed a bug in scheduler driver to properly erase
'savedOffers'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22148/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Niklas Nielsen.
Repository: mesos-git
Description
-------
Noticed the warning ("Attempting to launch task..with unknown offer") when running tests that were launching multiple tasks. I think this was introduced when we added the ability to launch tasks with multiple offers.
Diffs
-----
src/sched/sched.cpp be23e012fba99363b72b749b110f12ce3c902014
Diff: https://reviews.apache.org/r/22148/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 22148: Fixed a bug in scheduler driver to properly erase
'savedOffers'.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22148/#review44560
-----------------------------------------------------------
Ship it!
Good find!
src/sched/sched.cpp
<https://reviews.apache.org/r/22148/#comment78979>
Use 'contains' instead of 'count' while we're at it?
- Ben Mahler
On June 2, 2014, 5:59 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22148/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 5:59 p.m.)
>
>
> Review request for mesos, Ben Mahler and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Noticed the warning ("Attempting to launch task..with unknown offer") when running tests that were launching multiple tasks. I think this was introduced when we added the ability to launch tasks with multiple offers.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp be23e012fba99363b72b749b110f12ce3c902014
>
> Diff: https://reviews.apache.org/r/22148/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 22148: Fixed a bug in scheduler driver to properly erase
'savedOffers'.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22148/#review44785
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22148]
All tests passed.
- Mesos ReviewBot
On June 3, 2014, 10:58 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22148/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 10:58 p.m.)
>
>
> Review request for mesos, Ben Mahler and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Noticed the warning ("Attempting to launch task..with unknown offer") when running tests that were launching multiple tasks. I think this was introduced when we added the ability to launch tasks with multiple offers.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp be23e012fba99363b72b749b110f12ce3c902014
>
> Diff: https://reviews.apache.org/r/22148/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 22148: Fixed a bug in scheduler driver to properly erase
'savedOffers'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22148/
-----------------------------------------------------------
(Updated June 3, 2014, 10:58 p.m.)
Review request for mesos, Ben Mahler and Niklas Nielsen.
Changes
-------
rebased. NNFR.
Repository: mesos-git
Description
-------
Noticed the warning ("Attempting to launch task..with unknown offer") when running tests that were launching multiple tasks. I think this was introduced when we added the ability to launch tasks with multiple offers.
Diffs (updated)
-----
src/sched/sched.cpp be23e012fba99363b72b749b110f12ce3c902014
Diff: https://reviews.apache.org/r/22148/diff/
Testing
-------
make check
Thanks,
Vinod Kone